| Summary: | [Extra zoom mode] Implement multiple and single select menus | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | WebKit Misc. | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bdakin, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2018-02-05 20:18:58 PST
Created attachment 333154 [details]
Patch
Comment on attachment 333154 [details] Patch Attachment 333154 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6377395 New failing tests: media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html Created attachment 333156 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 333156 [details]
Archive of layout-test-results from ews100 for mac-sierra
Pretty sure this macOS media test failure isn't related...
Comment on attachment 333154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333154&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4353 > + for (size_t index = 0; index < self.assistedNodeSelectOptions.size(); ++index) { what’s up with this legacy loop? Comment on attachment 333154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333154&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4353 >> + for (size_t index = 0; index < self.assistedNodeSelectOptions.size(); ++index) { > > what’s up with this legacy loop? Oh, good point — changed this to `for auto&`. (In reply to Wenson Hsieh from comment #6) > Comment on attachment 333154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=333154&action=review > > >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4353 > >> + for (size_t index = 0; index < self.assistedNodeSelectOptions.size(); ++index) { > > > > what’s up with this legacy loop? > > Oh, good point — changed this to `for auto&`. ...actually, nevermind — Vector::findMatching is even cleaner :) Created attachment 333175 [details]
Pending PoSP
Comment on attachment 333175 [details] Pending PoSP Clearing flags on attachment: 333175 Committed r228245: <https://trac.webkit.org/changeset/228245> |