Summary: | There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||
Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, darin, keith_miller, mark.lam, rmondello, rniwa, saam, sam, webkit-bug-importer | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2018-02-05 20:09:38 PST
Created attachment 333153 [details]
Patch
This seems weird to me. This would mean that the same code written for a normal page would run different in an isolated world. If we want to make coding in an isolated world easier, I would rather it be an opt-in mode for the specific isolated world. Created attachment 333262 [details]
WIP Patch
Created attachment 333264 [details]
Patch
Created attachment 333265 [details]
Patch
(In reply to Sam Weinig from comment #3) > This seems weird to me. This would mean that the same code written for a > normal page would run different in an isolated world. If we want to make > coding in an isolated world easier, I would rather it be an opt-in mode for > the specific isolated world. Ok, made it opt-in at Cocoa/C API level. Comment on attachment 333265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333265&action=review This has implications in the structure of prototype objects. > Tools/TestWebKitAPI/Tests/WebKit/override-builtins-test.html:5 > +<input id="test" name="tagName"> Please add a test case in the main world as well. Created attachment 333349 [details]
Patch
Created attachment 333351 [details]
Patch
Created attachment 333352 [details]
Patch
Comment on attachment 333352 [details] Patch Rejecting attachment 333352 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urces/UnifiedSource17.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource17.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource8.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource8.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/6424076 Created attachment 333439 [details]
Patch
Comment on attachment 333439 [details] Patch Clearing flags on attachment: 333439 Committed r228309: <https://trac.webkit.org/changeset/228309> All reviewed patches have been landed. Closing bug. |