Bug 182524

Summary: There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, darin, keith_miller, mark.lam, rmondello, rniwa, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
WIP Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2018-02-05 20:09:38 PST
Make [OverrideBuiltins] a no-op outside the normal world. This is a legacy feature that is only needed for backward compatibility. Let's try and make it a no-op outside the normal world.
Attachments
Patch (4.42 KB, patch)
2018-02-05 20:12 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (5.77 KB, patch)
2018-02-06 21:14 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.04 KB, patch)
2018-02-06 21:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.10 KB, patch)
2018-02-06 21:53 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (26.42 KB, patch)
2018-02-07 18:50 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (28.34 KB, patch)
2018-02-07 19:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.23 KB, patch)
2018-02-07 19:05 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.25 KB, patch)
2018-02-08 19:20 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-02-05 20:09:58 PST
<rdar://problem/9057327>
Chris Dumez
Comment 2 2018-02-05 20:12:26 PST
Created attachment 333153 [details] Patch
Sam Weinig
Comment 3 2018-02-06 10:56:53 PST
This seems weird to me. This would mean that the same code written for a normal page would run different in an isolated world. If we want to make coding in an isolated world easier, I would rather it be an opt-in mode for the specific isolated world.
Chris Dumez
Comment 4 2018-02-06 21:14:16 PST
Created attachment 333262 [details] WIP Patch
Chris Dumez
Comment 5 2018-02-06 21:51:09 PST
Created attachment 333264 [details] Patch
Chris Dumez
Comment 6 2018-02-06 21:51:55 PST
<rdar://problem/37300983>
Chris Dumez
Comment 7 2018-02-06 21:53:26 PST
Created attachment 333265 [details] Patch
Chris Dumez
Comment 8 2018-02-06 21:55:43 PST
(In reply to Sam Weinig from comment #3) > This seems weird to me. This would mean that the same code written for a > normal page would run different in an isolated world. If we want to make > coding in an isolated world easier, I would rather it be an opt-in mode for > the specific isolated world. Ok, made it opt-in at Cocoa/C API level.
Ryosuke Niwa
Comment 9 2018-02-07 16:10:26 PST
Comment on attachment 333265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=333265&action=review This has implications in the structure of prototype objects. > Tools/TestWebKitAPI/Tests/WebKit/override-builtins-test.html:5 > +<input id="test" name="tagName"> Please add a test case in the main world as well.
Chris Dumez
Comment 10 2018-02-07 18:50:24 PST
Created attachment 333349 [details] Patch
Chris Dumez
Comment 11 2018-02-07 19:04:06 PST
Created attachment 333351 [details] Patch
Chris Dumez
Comment 12 2018-02-07 19:05:35 PST
Created attachment 333352 [details] Patch
WebKit Commit Bot
Comment 13 2018-02-08 19:08:42 PST
Comment on attachment 333352 [details] Patch Rejecting attachment 333352 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: urces/UnifiedSource17.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource17.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/UnifiedSource8.o /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource8.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/6424076
Chris Dumez
Comment 14 2018-02-08 19:20:26 PST
Created attachment 333439 [details] Patch
WebKit Commit Bot
Comment 15 2018-02-08 20:16:57 PST
Comment on attachment 333439 [details] Patch Clearing flags on attachment: 333439 Committed r228309: <https://trac.webkit.org/changeset/228309>
WebKit Commit Bot
Comment 16 2018-02-08 20:16:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.