Summary: | [GTK] WaylandCompositor misusing eglGetProcAddress | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Stone <daniel> | ||||
Component: | WebKitGTK | Assignee: | Miguel Gomez <magomez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, commit-queue, fcrozat, magomez, mcatanzaro | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
See Also: |
https://bugs.freedesktop.org/show_bug.cgi?id=104949 https://bugzilla.redhat.com/show_bug.cgi?id=1518674 https://bugzilla.redhat.com/show_bug.cgi?id=1553894 |
||||||
Attachments: |
|
Description
Daniel Stone
2018-02-05 09:33:39 PST
Mesa devs say "[WebKit] seems to be doing the most common and silly mistakes - uses the function pointers w/o checking for the extension string" in the upstream bug. We need to make sure we get this right everywhere, not just WaylandCompositor.cpp. Created attachment 333283 [details]
Patch
(In reply to Michael Catanzaro from comment #1) > Mesa devs say "[WebKit] seems to be doing the most common and silly mistakes > - uses the function pointers w/o checking for the extension string" in the > upstream bug. We need to make sure we get this right everywhere, not just > WaylandCompositor.cpp. I've fixed WaylandCompositor.cpp. The rest of the places calling eglGetProcAddress seem to be properly checking for the required extensions. Comment on attachment 333283 [details]
Patch
Thanks
Don't think my r+ etc counts here, but LGTM anyway! Comment on attachment 333283 [details] Patch Clearing flags on attachment: 333283 Committed r228272: <https://trac.webkit.org/changeset/228272> All reviewed patches have been landed. Closing bug. *** Bug 183289 has been marked as a duplicate of this bug. *** |