Bug 18248

Summary:

windows created by showModalDialog should not have minimize/maximize/restore buttons

Product:

WebKit

Reporter:

Robbie Paplin <rpaplin>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Trivial

CC:

aroben, darin, sfalken

Priority:

Keywords:

InRadar, PlatformOnly

Version:

525.x (Safari 3.1)

Hardware:

OS:

Windows Vista

Attachments:

Description	Flags
showModalDialog window capture on Windows Safari	none
alert window capture on Windows Safari	none
showModalDialog window capture on Windows Firefox	none
showModalDialog window capture on Windows Internet Explorer	none
Microsoft UI guidelines for title bar buttons for standard windows	none
Expected appearance when calling showModalDialog on Windows Safari	none

Robbie Paplin

Reported 2008-03-31 13:35:22 PDT

Description: According to Microsoft's User Interface Guidelines regarding title bars on dialog boxes, the title bar should only contain a Close button or Help & Close buttons. It should not contain Minimize, Maximize (or Restore) buttons. See http://msdn2.microsoft.com/en-us/library/bb226827.aspx Actual Results: windows created by showModalDialog in Window Safari have close, minimize & maximize buttons. Expected Results: I'd expect the windows created by showModalDialog in Windows Safari to have the same title bar as alerts in Windows Safari and a similar title bar as Windows Internet Explorer and Windows Firefox does (just a close button)

Attachments
showModalDialog window capture on Windows Safari (8.23 KB, image/png) 2008-03-31 14:00 PDT, Robbie Paplin	no flags	Details
alert window capture on Windows Safari (8.23 KB, image/png) 2008-03-31 14:02 PDT, Robbie Paplin	no flags	Details
showModalDialog window capture on Windows Firefox (11.38 KB, image/png) 2008-03-31 14:04 PDT, Robbie Paplin	no flags	Details
showModalDialog window capture on Windows Internet Explorer (13.64 KB, image/png) 2008-03-31 14:05 PDT, Robbie Paplin	no flags	Details
Microsoft UI guidelines for title bar buttons for standard windows (5.64 KB, image/png) 2008-03-31 14:08 PDT, Robbie Paplin	no flags	Details
Expected appearance when calling showModalDialog on Windows Safari (8.07 KB, image/png) 2008-03-31 14:10 PDT, Robbie Paplin	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Robbie Paplin

Comment 1 2008-03-31 14:00:36 PDT

Created attachment 20255 [details] showModalDialog window capture on Windows Safari

Robbie Paplin

Comment 2 2008-03-31 14:02:11 PDT

Created attachment 20256 [details] alert window capture on Windows Safari

Robbie Paplin

Comment 3 2008-03-31 14:04:21 PDT

Created attachment 20257 [details] showModalDialog window capture on Windows Firefox

Robbie Paplin

Comment 4 2008-03-31 14:05:25 PDT

Created attachment 20258 [details] showModalDialog window capture on Windows Internet Explorer

Robbie Paplin

Comment 5 2008-03-31 14:08:24 PDT

Created attachment 20259 [details] Microsoft UI guidelines for title bar buttons for standard windows

Robbie Paplin

Comment 6 2008-03-31 14:10:36 PDT

Created attachment 20260 [details] Expected appearance when calling showModalDialog on Windows Safari

Darin Adler

Comment 7 2008-03-31 14:11:09 PDT

This is actually an application responsibility, so it's a bug in Safari not in WebKit. Thus the bug will need to be closed here in bugs.webkit.org and opened as a Safari bug.

Robbie Paplin

Comment 8 2008-03-31 14:14:40 PDT

The dialog shown in the bug is from http://bugs.webkit.org/show_bug.cgi?id=18121

Mark Rowe (bdash)

Comment 9 2008-03-31 14:57:18 PDT

<rdar://problem/5832806>

Mark Rowe (bdash)

Comment 10 2008-03-31 14:58:11 PDT

As noted, this issue is in Safari and not in WebKit. Closing as INVALID to represent that this is not a WebKit issue and will be tracked via Radar.

Note You need to log in before you can comment on or make changes to this bug.