Bug 18247

Summary:

On Mac: showModalDialog doesn't follow Apple's Human Interface Guidelines

Product:

WebKit

Reporter:

Robbie Paplin <rpaplin>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Trivial

Keywords:

InRadar

Priority:

Version:

525.x (Safari 3.1)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
showModalDialog window capture on Mac Safari	none
alert window capture on Mac Safari	none
showModalDialog window capture on Mac Firefox	none
Apple UI guidelines for title bar buttons for standard windows	none
Expected appearance when calling showModalDialog on Mac Safari	none

Robbie Paplin

Reported 2008-03-31 13:09:47 PDT

Description: According to Apple's Human Interface Guidelines regarding Title Bar Buttons "Document and application windows always display active close and minimize buttons..." and "Alerts and modal dialogs do not display any of these buttons." See Figure 14-7 from http://developer.apple.com/documentation/UserExperience/Conceptual/OSXHIGuidelines/XHIGWindows/chapter_18_section_4.html#//apple_ref/doc/uid/20000961-TPXREF49 Actual Results: windows created by showModalDialog in Mac Safari have close & minimize buttons. Expected Results: I'd expect the windows created by showModalDialog in Mac Safari to have the same title bar as alerts in Mac Safari and a similar title bar as Mac Firefox does

Attachments
showModalDialog window capture on Mac Safari (14.02 KB, image/png) 2008-03-31 13:11 PDT, Robbie Paplin	no flags	Details
alert window capture on Mac Safari (10.56 KB, image/png) 2008-03-31 13:12 PDT, Robbie Paplin	no flags	Details
showModalDialog window capture on Mac Firefox (12.53 KB, image/png) 2008-03-31 13:12 PDT, Robbie Paplin	no flags	Details
Apple UI guidelines for title bar buttons for standard windows (11.52 KB, image/png) 2008-03-31 13:13 PDT, Robbie Paplin	no flags	Details
Expected appearance when calling showModalDialog on Mac Safari (13.62 KB, image/png) 2008-03-31 13:14 PDT, Robbie Paplin	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Robbie Paplin

Comment 1 2008-03-31 13:11:39 PDT

Created attachment 20250 [details] showModalDialog window capture on Mac Safari

Robbie Paplin

Comment 2 2008-03-31 13:12:03 PDT

Created attachment 20251 [details] alert window capture on Mac Safari

Robbie Paplin

Comment 3 2008-03-31 13:12:34 PDT

Created attachment 20252 [details] showModalDialog window capture on Mac Firefox

Robbie Paplin

Comment 4 2008-03-31 13:13:29 PDT

Created attachment 20253 [details] Apple UI guidelines for title bar buttons for standard windows

Robbie Paplin

Comment 5 2008-03-31 13:14:21 PDT

Created attachment 20254 [details] Expected appearance when calling showModalDialog on Mac Safari

Robbie Paplin

Comment 6 2008-03-31 13:16:27 PDT

The dialog shown in the bug is from http://bugs.webkit.org/show_bug.cgi?id=18121

Mark Rowe (bdash)

Comment 7 2008-03-31 14:55:54 PDT

<rdar://problem/5832798>

Mark Rowe (bdash)

Comment 8 2008-03-31 14:58:29 PDT

As noted, this issue is in Safari and not in WebKit. Closing as INVALID to represent that this is not a WebKit issue and will be tracked via Radar.

Note You need to log in before you can comment on or make changes to this bug.