Bug 182458

Summary: Add DoNotProcessIncomingMessagesWhenWaitingForSyncReply to GetPlugins and RootViewToScreen
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit2Assignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ddkilzer, ews-watchlist, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 182449    
Attachments:
Description Flags
Adds the option none

Description Ryosuke Niwa 2018-02-02 22:10:08 PST 
I found two more sync IPCs that gets sent while ScriptDisallowedScope is present.
Add DoNotProcessIncomingMessagesWhenWaitingForSyncReply to those syncSend calls.
Comment 1 Radar WebKit Bug Importer 2018-02-02 22:11:08 PST 
<rdar://problem/37183043>
Comment 2 Ryosuke Niwa 2018-02-02 23:09:12 PST 
Created attachment 333029 [details]
Adds the option
Comment 3 EWS Watchlist 2018-02-02 23:11:02 PST 
Attachment 333029 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/Plugins/WebPluginInfoProvider.cpp:148:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2018-02-05 13:10:45 PST 
Comment on attachment 333029 [details]
Adds the option

r=me
Comment 5 WebKit Commit Bot 2018-02-05 14:13:56 PST 
Comment on attachment 333029 [details]
Adds the option

Clearing flags on attachment: 333029

Committed r228125: <https://trac.webkit.org/changeset/228125>
Comment 6 WebKit Commit Bot 2018-02-05 14:13:58 PST 
All reviewed patches have been landed.  Closing bug.