Bug 182446

Summary: [Win] Enable multi cpu building on MSBuild.
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, dbates, don.olmstead, ews-watchlist, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
none
PATCH none

Basuke Suzuki
Reported 2018-02-02 11:57:58 PST
Compiling itself already uses multi cores, but other stuff is still on single core. This patch enables that by passing an argument to MSBuild.exe.
Attachments
patch (1.54 KB, patch)
2018-02-02 12:03 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
patch (1.88 KB, patch)
2018-02-02 12:20 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
PATCH (1.88 KB, patch)
2018-02-03 20:07 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-02-02 12:03:15 PST
Created attachment 332990 [details] patch
Basuke Suzuki
Comment 2 2018-02-02 12:15:11 PST
32 min => 21 min ! (Core i7-8700K 3.7GHz 6 core)
Basuke Suzuki
Comment 3 2018-02-02 12:20:26 PST
Created attachment 332992 [details] patch
Alex Christensen
Comment 4 2018-02-02 16:45:52 PST
Comment on attachment 332992 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=332992&action=review > Tools/Scripts/webkitdirs.pm:438 > + $numberOfCPUs = 1; Don't we want an implementation for non-cygwin Windows?
Daniel Bates
Comment 5 2018-02-02 19:47:33 PST
Comment on attachment 332992 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=332992&action=review > Tools/Scripts/webkitdirs.pm:1922 > + my $maxCpuCount = '/maxcpucount:' . numberOfCPUs(); Nit: maxCpuCount => maxCPUCount (Since CPU is an abbreviation)
Don Olmstead
Comment 6 2018-02-02 20:54:22 PST
(In reply to Alex Christensen from comment #4) > Comment on attachment 332992 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332992&action=review > > > Tools/Scripts/webkitdirs.pm:438 > > + $numberOfCPUs = 1; > > Don't we want an implementation for non-cygwin Windows? I THINK the environment variable checked above should be set on windows. There looks to be a perl module that will tell you the number of CPUs as well http://search.cpan.org/~burak/Sys-Info-Base-0.7802/lib/Sys/Info/Device/CPU.pm which sounds like it calls into WMI
Basuke Suzuki
Comment 7 2018-02-03 20:07:10 PST
> Don't we want an implementation for non-cygwin Windows? Don is right. Here's the source. https://msdn.microsoft.com/en-us/library/fd7hxfdd(v=vs.84).aspx > Nit: maxCpuCount => maxCPUCount > (Since CPU is an abbreviation) Right. I'll send another patch.
Basuke Suzuki
Comment 8 2018-02-03 20:07:46 PST
Created attachment 333044 [details] PATCH
WebKit Commit Bot
Comment 9 2018-02-05 11:15:14 PST
Comment on attachment 333044 [details] PATCH Clearing flags on attachment: 333044 Committed r228106: <https://trac.webkit.org/changeset/228106>
WebKit Commit Bot
Comment 10 2018-02-05 11:15:15 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-02-05 11:19:54 PST
<rdar://problem/37244015>
Note You need to log in before you can comment on or make changes to this bug.