Bug 18239

Summary: [Gtk] Build breaks if SVG is enabled but SVG Fonts disabled
Product: WebKit Reporter: Marcin Juszkiewicz <openembedded>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, jchaffraix, jmalonzo
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
build error log
none
Add SVG_FONTS in SVGAltGlyphElement.idl oliver: review+

Marcin Juszkiewicz
Reported 2008-03-31 10:40:21 PDT
Today I tried to upgrade Webkit in our tree to revision newer then 30762 which we used. Build of 31457 rev failed so I tried 31450 and 31400 to check does it happen in older versions too - it was. On IRC Julien Chaffraix told me that error is due to wrong use of ENABLE(SVG) ENABLE(SVG_FONTS) flags in SVGAltGlyphElement.h and JSVGAltGlyphElement.h header files. Configure flags used was "--enable-svg --enable-debug=no --enable-icon-database=yes". I tried to cross compile for ARM architecture using Poky Linux buildsystem.
Attachments
build error log (18.27 KB, text/plain)
2008-03-31 10:40 PDT, Marcin Juszkiewicz 		no flags
Details
Add SVG_FONTS in SVGAltGlyphElement.idl (1.15 KB, patch)
2008-04-13 16:09 PDT, Jan Alonzo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Marcin Juszkiewicz
Comment 1 2008-03-31 10:40:53 PDT
Created attachment 20238 [details] build error log
Julien Chaffraix
Comment 2 2008-03-31 11:04:06 PDT
The issue here is that we try to compile files that need SVG_FONTS even if we do not have specified it. Switching the platform to Gtk (I thought first that the problem was cross-platform but after a second thought it may not be).
Marcin Juszkiewicz
Comment 3 2008-03-31 11:14:20 PDT
NOTE: package webkit-gtk-0.1+svnr31467-r4: task do_build: completed adding "--enable-svg-fonts" helped
Jan Alonzo
Comment 4 2008-04-13 16:09:57 PDT
Created attachment 20508 [details] Add SVG_FONTS in SVGAltGlyphElement.idl The patch adds SVG_FONTS in the Conditional section of SVGAltGlyphElement.idl to prevent the generated source files from being compiled.
Alp Toker
Comment 5 2008-04-13 19:49:03 PDT
Landed in r31855.
Note You need to log in before you can comment on or make changes to this bug.