Bug 182384

Summary: [JHBuild] Add libva in moduleset
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, aperez, bugs-noreply, calvaris, clopez, ews-watchlist, ltilve, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch calvaris: review+

Philippe Normand
Reported 2018-02-01 06:33:51 PST
And patch it to remove annoying verbose printfs cluttering layout test output.
Attachments
Patch (3.20 KB, patch)
2018-02-01 06:47 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
Patch (3.28 KB, patch)
2018-02-07 02:13 PST, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2018-02-01 06:47:02 PST
Created attachment 332871 [details] Patch
Carlos Alberto Lopez Perez
Comment 2 2018-02-06 03:21:49 PST
Comment on attachment 332871 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332871&action=review > Tools/gstreamer/jhbuild.modules:122 > + <autotools id="libva" autogenargs="--enable-va-messaging=no"> > + <branch module="intel/libva/archive/${version}.tar.gz" version="2.0.0" > + checkoutdir="libva-${version}" repo="github-tarball"/> > + </autotools> github on-the-fly tarballs/zips are not guaranteed to have stable hashes and should be avoided. Example of the issue: https://github.com/easybuilders/easybuild-easyconfigs/issues/5151 Instead of using this resource, please use the tarball properly released at https://github.com/intel/libva/releases/download/2.0.0/libva-2.0.0.tar.bz2 which has this sha1sum: https://github.com/intel/libva/releases/download/2.0.0/libva-2.0.0.tar.bz2.sha1sum Notice the diference in the URI ( /archive/XXX vs /release/XXX )
Philippe Normand
Comment 3 2018-02-07 02:13:00 PST
Created attachment 333274 [details] Patch
Xabier Rodríguez Calvar
Comment 4 2018-02-07 02:52:30 PST
Comment on attachment 333274 [details] Patch This reminds me that we might want to create a common GStreamer script for dependencies.
Philippe Normand
Comment 5 2018-02-07 03:33:03 PST
Committed r228221: <https://trac.webkit.org/changeset/228221>
Radar WebKit Bug Importer
Comment 6 2018-02-07 03:34:38 PST
<rdar://problem/37309231>
Note You need to log in before you can comment on or make changes to this bug.