Bug 182366

Summary: Layout Test http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html is flaky
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: New BugsAssignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, ddkilzer, ryanhaddad, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Matt Lewis 2018-01-31 17:16:31 PST
The following layout test is a flaky timeout on macOS WK2

http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html

Probable cause:

The timeouts go back further than the flakiness dashboard shows.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fnon-prevalent-resource-with-user-interaction.html

https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r227933%20(2656)/results.html
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/builds/2656


Diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/resourceLoadStatistics/non-prevalent-resource-with-user-interaction-actual.txt
@@ -1,2 +1,5 @@
-PASS Cookie not deleted.
+#PID UNRESPONSIVE - com.apple.WebKit.WebContent.Development (pid 62073)
+FAIL: Timed out waiting for notifyDone to be called
 
+#EOF
+#EOF
Comment 1 Radar WebKit Bug Importer 2018-01-31 17:16:59 PST
<rdar://problem/37094805>
Comment 2 Matt Lewis 2018-02-01 15:43:15 PST
Skipped for now in:
https://trac.webkit.org/changeset/227986/webkit
Comment 3 Ryan Haddad 2018-02-02 17:41:06 PST
Skipping this test seems to have caused http/tests/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html to time out.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FresourceLoadStatistics%2Fnon-prevalent-resource-without-user-interaction.html
Comment 4 Alexey Proskuryakov 2018-02-06 12:30:47 PST
Perhaps running http/tests/resourceLoadStatistics tests with --repeat-each will help determine which test is the real culprit. Matt, would you be willing to try that out?
Comment 5 John Wilander 2018-02-07 16:06:32 PST
Created attachment 333330 [details]
Patch
Comment 6 John Wilander 2018-02-07 16:07:25 PST
Just waiting for EWS feedback on this one before I land.
Comment 7 John Wilander 2018-02-07 17:00:38 PST
Comment on attachment 333330 [details]
Patch

Failing iOS-sim tests are unrelated.
Comment 8 WebKit Commit Bot 2018-02-07 17:25:11 PST
Comment on attachment 333330 [details]
Patch

Clearing flags on attachment: 333330

Committed r228252: <https://trac.webkit.org/changeset/228252>
Comment 9 WebKit Commit Bot 2018-02-07 17:25:12 PST
All reviewed patches have been landed.  Closing bug.