Bug 182337

Summary:

Change SWServer::claim to set the iterator value as soon as possible

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Service Workers

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Patch for landing	none

youenn fablet

Reported 2018-01-31 09:18:01 PST

This will remove potential risks to have the iterator being invalidated when removing the client using registration.

Attachments
Patch (1.71 KB, patch) 2018-01-31 09:19 PST, youenn fablet	no flags	Details Formatted Diff Diff
Patch for landing (1.67 KB, patch) 2018-01-31 09:23 PST, youenn fablet	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.64 MB, application/zip) 2018-01-31 10:28 PST, EWS Watchlist	no flags	Details
Patch for landing (2.04 KB, patch) 2018-01-31 13:43 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-01-31 09:19:52 PST

Created attachment 332765 [details] Patch

Radar WebKit Bug Importer

Comment 2 2018-01-31 09:20:31 PST

<rdar://problem/37073164>

youenn fablet

Comment 3 2018-01-31 09:23:08 PST

Created attachment 332766 [details] Patch for landing

EWS Watchlist

Comment 4 2018-01-31 10:28:41 PST

Comment on attachment 332766 [details] Patch for landing Attachment 332766 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6292891 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/claim-using-registration.https.html imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html

EWS Watchlist

Comment 5 2018-01-31 10:28:43 PST

Created attachment 332778 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 6 2018-01-31 10:35:34 PST

Comment on attachment 332766 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=332766&action=review > Source/WebCore/workers/service/server/SWServer.cpp:426 > if (auto* controllingRegistration = registrationFromServiceWorkerIdentifier(result.iterator->value)) You're using result.iterator->value here after you've overwrote its value. this is wrong.

youenn fablet

Comment 7 2018-01-31 13:43:13 PST

Created attachment 332799 [details] Patch for landing

WebKit Commit Bot

Comment 8 2018-01-31 14:40:14 PST

Comment on attachment 332799 [details] Patch for landing Clearing flags on attachment: 332799 Committed r227932: <https://trac.webkit.org/changeset/227932>

WebKit Commit Bot

Comment 9 2018-01-31 14:40:16 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.