Bug 182316

Summary: com.apple.WebKit.Storage crashing at com.apple.WebCore: WebCore::SWServerRegistration::removeClientUsingRegistration
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2018-01-30 16:46:37 PST
com.apple.WebKit.Storage crashing at com.apple.WebCore: WebCore::SWServerRegistration::removeClientUsingRegistration. This means SWServer.m_clientToControllingWorker and m_clientsUsingRegistration might currently get out of sync.
Attachments
Patch (2.32 KB, patch)
2018-01-30 16:49 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.96 KB, patch)
2018-01-31 09:25 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-01-30 16:47:20 PST
<rdar://problem/37025976>
youenn fablet
Comment 2 2018-01-30 16:49:52 PST
Created attachment 332724 [details] Patch
Chris Dumez
Comment 3 2018-01-31 09:19:54 PST
Comment on attachment 332724 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332724&action=review > Source/WebCore/workers/service/server/SWServerRegistration.cpp:184 > + if (iterator != m_clientsUsingRegistration.end()) { I would just return early. I don't think we should run handleClientUnload() if we did not really remove a client. handleClientUnload() relies on m_clientsUsingRegistration which technically has not changed.
youenn fablet
Comment 4 2018-01-31 09:25:07 PST
Created attachment 332767 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-01-31 11:14:56 PST
Comment on attachment 332767 [details] Patch for landing Clearing flags on attachment: 332767 Committed r227909: <https://trac.webkit.org/changeset/227909>
WebKit Commit Bot
Comment 6 2018-01-31 11:14:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.