Bug 182307

Summary: [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa, ryanhaddad, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2018-01-30 13:49:40 PST
After <https://trac.webkit.org/r223440>, we now always deliver sanitized markup if the page asks for "text/html" from a DataTransfer. UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations writes "public.html" to the UIPasteboard using platform API, and then checks for the value of DataTransfer.getData('text/html') when pasting. After r223440, the requested HTML now contains inline styles, where it was simply the markup string written by the platform before.
Attachments
Patch (4.59 KB, patch)
2018-01-30 14:28 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2018-01-30 13:49:59 PST
<rdar://problem/36041485>
Wenson Hsieh
Comment 2 2018-01-30 14:22:25 PST
This is very similar to the existing tests PasteHTML.SanitizesHTML (and PasteWebArchive.SanitizesHTML, which is for macOS only). In both cases, we're writing web content to the pasteboard via platform API, and then expecting sanitized markup for "text/html". Both the aforementioned tests are indifferent to specific inline styles captured in the sanitized markup, so this failing test should be updated to match.
Wenson Hsieh
Comment 3 2018-01-30 14:28:12 PST
Created attachment 332709 [details] Patch
Wenson Hsieh
Comment 4 2018-01-30 14:32:36 PST
Comment on attachment 332709 [details] Patch Thanks for the review!
WebKit Commit Bot
Comment 5 2018-01-30 15:06:01 PST
Comment on attachment 332709 [details] Patch Clearing flags on attachment: 332709 Committed r227859: <https://trac.webkit.org/changeset/227859>
WebKit Commit Bot
Comment 6 2018-01-30 15:06:03 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.