Bug 182295

Summary: W3C: WebAutomationSession::navigateBrowsingContext should implement "navigate to" command, steps 5–8
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebDriverAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: bburg, cgarcia, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description BJ Burg 2018-01-30 09:17:51 PST
In both safaridriver and webkit's driver, none of the checks in steps 5-8 (including "post-navigation checks") are being done at all. This needs to happen in the WebKit side since it depends on examining the document loader / main resource response.
Comment 1 BJ Burg 2018-01-30 09:21:10 PST
Forgot the link:

https://w3c.github.io/webdriver/webdriver-spec.html#navigate-to

Practically speaking, we should be not running the page load timeout if this appears to be a same-document navigation (i.e., to a fragment). We also need to adjust the response if the navigation failed for some reason (handled by the "post-navigation checks" algorithm).

This command already does most steps of "wait for navigation to complete", though I haven't audited the code against the spec to see if we are missing any steps. It's likely that W3C test coverage is not good for the finer points of the algorithm.
Comment 2 Radar WebKit Bug Importer 2018-01-30 09:29:47 PST
<rdar://problem/37031629>