Bug 182288 – Update test262 to Jan 30 version

• Component: New Bugs
• Status: RESOLVED FIXED

[Yusuke Suzuki]

Update Test262

[Yusuke Suzuki]

Created attachment 332651 [details]
Patch

[Yusuke Suzuki]

Created attachment 332658 [details]
Patch

[Yusuke Suzuki]

(In reply to Yusuke Suzuki from comment #2)
> Created attachment 332658 [details]
> Patch

Even with the latest ToT, patching always fails. I guess it is due to the size of patch...?

[Saam Barati]

rs=me

[Yusuke Suzuki]

Created attachment 332868 [details]
Patch

[Yusuke Suzuki]

Super funny thing is that, we cannot import test262 because SVN rejects its diff.
I'm not sure what happens right now. I guess that newer test262 includes some very tricky characters, which makes diff crazy. (like, u2028 / u2029?).
I'm still investigating...

[Yusuke Suzuki]

Created attachment 332979 [details]
Patch

[EWS Watchlist]

Attachment 332979 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/steps/checkstyle.py", line 66, in run
    self._tool.executive.run_and_throw_if_fail(self._tool.deprecated_port().check_webkit_style_command() + args, cwd=self._tool.scm().checkout_root)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 135, in run_and_throw_if_fail
    exit_code = self._run_command_with_teed_output(args, child_stdout, **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 107, in _run_command_with_teed_output
    **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 479, in popen
    return subprocess.Popen(string_args, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 7] Argument list too long


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Created attachment 332986 [details]
Patch

[EWS Watchlist]

Attachment 332986 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/steps/checkstyle.py", line 66, in run
    self._tool.executive.run_and_throw_if_fail(self._tool.deprecated_port().check_webkit_style_command() + args, cwd=self._tool.scm().checkout_root)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 135, in run_and_throw_if_fail
    exit_code = self._run_command_with_teed_output(args, child_stdout, **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 107, in _run_command_with_teed_output
    **kwargs)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 479, in popen
    return subprocess.Popen(string_args, **kwargs)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1335, in _execute_child
    raise child_exception
OSError: [Errno 22] Invalid argument


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 332986 [details]
Patch

Clearing flags on attachment: 332986

Committed r228028: <https://trac.webkit.org/changeset/228028>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37169557>

[Ryan Haddad]

Tests are failing to run on the bots after this change:

https://build.webkit.org/builders/Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/383

./Tools/Scripts/run-jsc-stress-tests:1405:in `realpath': No such file or directory - /Volumes/Data/slave/sierra-debug-tests-test262/build/JSTests/test262/test/language/expressions/assignment/white-space.js (Errno::ENOENT)

[Ryan Haddad]

(In reply to Ryan Haddad from comment #14)
> Tests are failing to run on the bots after this change:
> 
> https://build.webkit.org/builders/
> Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/383
> 
> ./Tools/Scripts/run-jsc-stress-tests:1405:in `realpath': No such file or
> directory -
> /Volumes/Data/slave/sierra-debug-tests-test262/build/JSTests/test262/test/
> language/expressions/assignment/white-space.js (Errno::ENOENT)
Removed this test from test262.yaml in https://trac.webkit.org/r228039

[Yusuke Suzuki]

(In reply to Ryan Haddad from comment #15)
> (In reply to Ryan Haddad from comment #14)
> > Tests are failing to run on the bots after this change:
> > 
> > https://build.webkit.org/builders/
> > Apple%20Sierra%20Debug%20Test262%20%28Tests%29/builds/383
> > 
> > ./Tools/Scripts/run-jsc-stress-tests:1405:in `realpath': No such file or
> > directory -
> > /Volumes/Data/slave/sierra-debug-tests-test262/build/JSTests/test262/test/
> > language/expressions/assignment/white-space.js (Errno::ENOENT)
> Removed this test from test262.yaml in https://trac.webkit.org/r228039

Oops, thanks!

[Yusuke Suzuki]

Committed r228047: <https://trac.webkit.org/changeset/228047>