Bug 182273 – Release assert in updateLayout while waiting for sync reply to WebPageProxy::HasInsecureContent

• Component: WebKit2
• Status: RESOLVED FIXED

[Ryosuke Niwa]

e.g.
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00007fff3ba28d34 WebCore::Document::updateLayout() + 308
1   com.apple.WebCore             	0x00007fff3baec79e WebCore::VisibleSelection::toNormalizedRange() const + 62
2   com.apple.WebCore             	0x00007fff3c6aeb27 WebCore::Editor::selectedText(unsigned short) const + 39
3   com.apple.WebCore             	0x00007fff3bb5ca30 WebCore::Editor::selectedText() const + 16
4   com.apple.WebCore             	0x00007fff3bb5c969 WebCore::Editor::stringSelectionForPasteboard() + 41
5   com.apple.WebKit              	0x00007fff3d255e55 WebKit::WebPage::getStringSelectionForPasteboard(WTF::String&) + 109
6   com.apple.WebKit              	0x00007fff3d4a4ce0 void IPC::handleMessage<Messages::WebPage::GetStringSelectionForPasteboard, WebKit::WebPage, void (WebKit::WebPage::*)(WTF::String&)>(IPC::Decoder&, IPC::Encoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WTF::String&)) + 48
7   com.apple.WebKit              	0x00007fff3d2ef58f IPC::MessageReceiverMap::dispatchSyncMessage(IPC::Connection&, IPC::Decoder&, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >&) + 141
8   com.apple.WebKit              	0x00007fff3d504bfc WebKit::WebProcess::didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >&) + 32
9   com.apple.WebKit              	0x00007fff3d2bf271 IPC::Connection::dispatchSyncMessage(IPC::Decoder&) + 203
10  com.apple.WebKit              	0x00007fff3d2bc93e IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 104
11  com.apple.WebKit              	0x00007fff3d2bc81b IPC::Connection::SyncMessageState::dispatchMessages(IPC::Connection*) + 235
12  com.apple.WebKit              	0x00007fff3d2bde64 IPC::Connection::waitForSyncReply(unsigned long long, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) + 206
13  com.apple.WebKit              	0x00007fff3d2bd6d6 IPC::Connection::sendSyncMessage(unsigned long long, std::__1::unique_ptr<IPC::Encoder, std::__1::default_delete<IPC::Encoder> >, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) + 292
14  com.apple.WebKit              	0x00007fff3d4552d4 bool IPC::Connection::sendSync<Messages::WebPageProxy::HasInsecureContent>(Messages::WebPageProxy::HasInsecureContent&&, Messages::WebPageProxy::HasInsecureContent::Reply&&, unsigned long long, WTF::Seconds, WTF::OptionSet<IPC::SendSyncOption>) + 154
15  com.apple.WebKit              	0x00007fff3d2468fe WebKit::WebFrameLoaderClient::savePlatformDataToCachedFrame(WebCore::CachedFrame*) + 120
16  com.apple.WebCore             	0x00007fff3c708c37 WebCore::CachedFrame::CachedFrame(WebCore::Frame&) + 535
17  com.apple.WebCore             	0x00007fff3c708b58 WebCore::CachedFrame::CachedFrame(WebCore::Frame&) + 312
18  com.apple.WebCore             	0x00007fff3c70aa9e WebCore::PageCache::addIfCacheable(WebCore::HistoryItem&, WebCore::Page*) + 478
19  com.apple.WebCore             	0x00007fff3b9b1190 WebCore::FrameLoader::commitProvisionalLoad() + 272
20  com.apple.WebCore             	0x00007fff3ba008b1 WebCore::DocumentLoader::commitLoad(char const*, int) + 81
21  com.apple.WebCore             	0x00007fff3ba00438 WebCore::CachedRawResource::notifyClientsDataWasReceived(char const*, unsigned int) + 136
22  com.apple.WebCore             	0x00007fff3c8e77ba WebCore::CachedRawResource::updateBuffer(WebCore::SharedBuffer&) + 186
23  com.apple.WebCore             	0x00007fff3c8c4e6a WebCore::SubresourceLoader::didReceiveDataOrBuffer(char const*, int, WTF::RefPtr<WebCore::SharedBuffer, WTF::DumbPtrTraits<WebCore::SharedBuffer> >&&, long long, WebCore::DataPayloadType) + 186
24  com.apple.WebCore             	0x00007fff3c8c4da2 WebCore::SubresourceLoader::didReceiveData(char const*, unsigned int, long long, WebCore::DataPayloadType) + 34
25  com.apple.WebKit              	0x00007fff3d52ebc9 WebKit::WebResourceLoader::didReceiveData(IPC::DataReference const&, long long) + 85
26  com.apple.WebKit              	0x00007fff3d52f515 WebKit::WebResourceLoader::didReceiveWebResourceLoaderMessage(IPC::Connection&, IPC::Decoder&) + 277
27  com.apple.WebKit              	0x00007fff3d340dd9 WebKit::NetworkProcessConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 455
28  com.apple.WebKit              	0x00007fff3d2bc94d IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119
29  com.apple.WebKit              	0x00007fff3d2bf48e IPC::Connection::dispatchOneMessage() + 176
30  com.apple.JavaScriptCore      	0x00007fff31f584fc WTF::RunLoop::performWork() + 236
31  com.apple.JavaScriptCore      	0x00007fff31f58792 WTF::RunLoop::performWork(void*) + 34

<rdar://problem/36931122>

[Ryosuke Niwa]

Created attachment 332616 [details]
Fixes the bug

[WebKit Commit Bot]

Comment on attachment 332616 [details]
Fixes the bug

Clearing flags on attachment: 332616

Committed r227772: <https://trac.webkit.org/changeset/227772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37016054>