Bug 182225 – Support calc() in webkit-gradient and cross-fade

• Component: CSS
• Status: RESOLVED FIXED

[Chris Nardi]

Support calc() in webkit-gradient and cross-fade

[Chris Nardi]

Created attachment 332494 [details]
Patch

[Chris Nardi]

Created attachment 332495 [details]
Patch

[Chris Nardi]

Created attachment 332497 [details]
Add expectations

[EWS Watchlist]

Comment on attachment 332497 [details]
Add expectations

Attachment 332497 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6243651

New failing tests:
css3/calc/cross-fade-calc.html
css3/calc/webkit-gradient-calc.html

[EWS Watchlist]

Created attachment 332499 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Chris Nardi]

Created attachment 332500 [details]
Fix expectations

[Chris Nardi]

Created attachment 332721 [details]
Change order of summary in changelogs

[Chris Nardi]

simon.fraser@, could you review?

[Simon Fraser (smfr)]

Comment on attachment 332721 [details]
Change order of summary in changelogs

View in context: https://bugs.webkit.org/attachment.cgi?id=332721&action=review

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:869
> +        if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))

This could be if (auto percentValue = consumePercent(args, ValueRangeAll))

> Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1231
> +    if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> +        percentage = CSSValuePool::singleton().createValue(clampTo<double>(percentValue->doubleValue() / 100.0, 0, 1), CSSPrimitiveValue::UnitType::CSS_NUMBER);
> +    else if (RefPtr<CSSPrimitiveValue> numberValue = consumeNumber(args, ValueRangeAll))

You could use auto here too.

[Chris Nardi]

Created attachment 338351 [details]
Use auto

[Chris Nardi]

(In reply to Simon Fraser (smfr) from comment #9)
> Comment on attachment 332721 [details]
> Change order of summary in changelogs
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332721&action=review
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:869
> > +        if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> 
> This could be if (auto percentValue = consumePercent(args, ValueRangeAll))
> 
> > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1231
> > +    if (RefPtr<CSSPrimitiveValue> percentValue = consumePercent(args, ValueRangeAll))
> > +        percentage = CSSValuePool::singleton().createValue(clampTo<double>(percentValue->doubleValue() / 100.0, 0, 1), CSSPrimitiveValue::UnitType::CSS_NUMBER);
> > +    else if (RefPtr<CSSPrimitiveValue> numberValue = consumeNumber(args, ValueRangeAll))
> 
> You could use auto here too.

I changed both situations to use auto.

[WebKit Commit Bot]

Comment on attachment 338351 [details]
Use auto

Clearing flags on attachment: 338351

Committed r230816: <https://trac.webkit.org/changeset/230816>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39574509>