| Summary: | Web Inspector: Replace Object.shallowMerge with ES2018 spread operator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 332488 [details]
Patch
My only hesitation to this is that we might get collisions between keys (such as if we chain an options variable between functions), but I think that will be very rare
Comment on attachment 332488 [details]
Patch
r=me
Comment on attachment 332488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332488&action=review > Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:68 > - return WI.linkifyNodeReferenceElement(node, link, Object.shallowMerge(options, {displayName})); > + return WI.linkifyNodeReferenceElement(node, link, {...options, displayName}); I find this a little harder to read / understand, but I suppose its fine. Comment on attachment 332488 [details] Patch Clearing flags on attachment: 332488 Committed r227864: <https://trac.webkit.org/changeset/227864> All reviewed patches have been landed. Closing bug. |
Object.shallowMerge defined in Utilities.js is no longer needed with ES2018 spread operator. Object.shallowMerge(a, b) can be replaced with: {...a, ...b}