Bug 18218

Summary: [Gtk] segfault when clicking on a disabled button
Product: WebKit Reporter: Zoltan Dome <islandofcalmness>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp, jchaffraix, jmalonzo, zuh
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
test file for bug
none
Add a null check before using the focused frame alp: review-

Zoltan Dome
Reported 2008-03-30 09:16:36 PDT
Webkit segfaults when clicking on a disabled button. This only happens when the disabled button is on the first page loaded by the engine AND is the first thing clicked on. So, for example, if I start GtkLauncher with a test-file and click the button, it crashes, but it doesn't crash if I click somewhere else on the page first.
Attachments
test file for bug (32 bytes, text/html)
2008-03-30 09:17 PDT, Zoltan Dome 		no flags
Details
Add a null check before using the focused frame (1.27 KB, patch)
2008-04-13 19:30 PDT, Jan Alonzo 		alp: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zoltan Dome
Comment 1 2008-03-30 09:17:59 PDT
Created attachment 20212 [details] test file for bug
Julien Chaffraix
Comment 2 2008-04-09 08:56:08 PDT
Confirmed on ToT. The cause is in webkit_web_view_button_release_event (webkitwebview.cpp) when focusFrame is null. There is no null check so we call one of focusFrame's methods which results in a crash.
Jan Alonzo
Comment 3 2008-04-13 19:30:34 PDT
Created attachment 20511 [details] Add a null check before using the focused frame The patch checks for a null focusedFrame before calling the event handler. Thanks jchaffraix for the hint.
Kalle Vahlman
Comment 4 2008-04-17 04:02:12 PDT
Apparently this bug is also an issue with having a "mousedown" event handler that calls event.preventDefault(). I tested Jan's patch, and it fixes things for both cases.
Alp Toker
Comment 5 2008-04-18 04:01:31 PDT
Comment on attachment 20511 [details] Add a null check before using the focused frame r- The correct fix is to use the main frame for mouse events since it has the logic to bubble the event to the correct owner. I'll take care of this one.
Alp Toker
Comment 6 2008-04-18 04:16:15 PDT
(Different) fix landed in r32203. Thanks for tracking this issue Jan!
Note You need to log in before you can comment on or make changes to this bug.