Bug 182147

Summary: [macOS] MiniBrowser isn’t app-sandboxed
Product: WebKit Reporter: mitz
Component: Tools / TestsAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, commit-queue, lforschler, sam, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=182340
Attachments:
Description Flags
Enable App Sandbox with an exception allowing read access to all files none

mitz
Reported 2018-01-25 14:08:27 PST
macOS MiniBrowser isn’t a sandboxed app.
Attachments
Enable App Sandbox with an exception allowing read access to all files (4.83 KB, patch)
2018-01-31 07:13 PST, mitz 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-01-25 14:14:21 PST
This implies that it should be?
mitz
Comment 2 2018-01-25 14:21:51 PST
(In reply to Simon Fraser (smfr) from comment #1) > This implies that it should be? If possible. Perhaps it’s not practical for the only test app we have to be sandboxed. But even in that case, there should be some sandboxed test app—maybe it’s MiniBrowser (and there’s some other non-sandboxed app for when you need to test that), or maybe it’s a new app.
Sam Weinig
Comment 3 2018-01-25 14:22:02 PST
Given that most (hopefully all) users of WKWebView are sandboxed apps, making MiniBrowser mimic that would useful in finding issues that affect them. I do think we need to balance that with ensuring MiniBrowser is useful for it's debugging duties.
mitz
Comment 4 2018-01-31 07:13:40 PST
Created attachment 332760 [details] Enable App Sandbox with an exception allowing read access to all files
WebKit Commit Bot
Comment 5 2018-01-31 11:13:37 PST
Comment on attachment 332760 [details] Enable App Sandbox with an exception allowing read access to all files Clearing flags on attachment: 332760 Committed r227908: <https://trac.webkit.org/changeset/227908>
WebKit Commit Bot
Comment 6 2018-01-31 11:13:38 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-31 11:14:22 PST
<rdar://problem/37078215>
Note You need to log in before you can comment on or make changes to this bug.