Bug 182136

Summary: [webkitpy] Stop modifying path information only when running on Cygwin
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: Tools / TestsAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, bfulgham, commit-queue, don.olmstead, ews-watchlist, glenn, jbedard, lforschler, pvollan, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Basuke Suzuki
Reported 2018-01-25 12:22:05 PST
On LayoutTestApacheHttpd, some path configuration is modified when platform is Windows. This modification is only required for AppleWin running on Cygwin. WinCairo uses native Windows environment, so the condition should be changed.
Attachments
Patch (2.18 KB, patch)
2018-01-25 12:24 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2018-01-25 12:24:22 PST
Created attachment 332299 [details] Patch
Per Arne Vollan
Comment 2 2018-01-25 12:59:29 PST
Comment on attachment 332299 [details] Patch R=me.
Jonathan Bedard
Comment 3 2018-01-25 13:08:05 PST
Can we wait until Windows EWS comes back green to land this?
Basuke Suzuki
Comment 4 2018-01-25 13:08:45 PST
Of course.
Basuke Suzuki
Comment 5 2018-01-25 13:11:32 PST
It is green, but win EWS doesn't say test passed. Does it actually run layout tests?
WebKit Commit Bot
Comment 6 2018-01-25 14:04:14 PST
Comment on attachment 332299 [details] Patch Clearing flags on attachment: 332299 Committed r227629: <https://trac.webkit.org/changeset/227629>
WebKit Commit Bot
Comment 7 2018-01-25 14:04:16 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-01-25 14:05:25 PST
<rdar://problem/36882114>
Jonathan Bedard
Comment 9 2018-01-25 15:13:16 PST
(In reply to Basuke Suzuki from comment #5) > It is green, but win EWS doesn't say test passed. Does it actually run > layout tests? I forgot about that....I think you are correct, windows EWS does not run layout tests.
Jonathan Bedard
Comment 10 2018-01-26 09:03:16 PST
The patch was picked up by CI, but something else seems to have broken windows http servers. They start failing here https://build.webkit.org/builders/Apple%20Win%207%20Debug%20%28Tests%29/builds/2015, but this is before <https://trac.webkit.org/changeset/227629>.
Note You need to log in before you can comment on or make changes to this bug.