Bug 18213

Summary: Add support for dot notation and object literals to SquirrelFish
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mjs, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch
oliver: review+
Revised proposed patch
none
Revised proposed patch mjs: review+

Cameron Zwarich (cpst)
Reported 2008-03-29 19:11:03 PDT
The next post has the patch.
Attachments
Proposed patch (11.69 KB, patch)
2008-03-29 19:12 PDT, Cameron Zwarich (cpst) 		oliver: review+
DetailsFormatted DiffDiff
Revised proposed patch (8.62 KB, patch)
2008-03-29 22:22 PDT, Cameron Zwarich (cpst) 		no flags
DetailsFormatted DiffDiff
Revised proposed patch (8.08 KB, patch)
2008-03-29 22:29 PDT, Cameron Zwarich (cpst) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1 2008-03-29 19:12:31 PDT
Created attachment 20204 [details] Proposed patch Here's the patch. Getters and setters don't actually work because FuncExprNode isn't implemented.
Cameron Zwarich (cpst)
Comment 2 2008-03-29 19:17:22 PDT
Doh, this patch hits a random GCC performance regression on an empty for loop. I'll see if it's fixable.
Cameron Zwarich (cpst)
Comment 3 2008-03-29 22:22:34 PDT
Created attachment 20207 [details] Revised proposed patch The performance regression was caused by the getters and setters. It might still be possible to fight with GCC to beat the regression, but I'll leave it for now.
Cameron Zwarich (cpst)
Comment 4 2008-03-29 22:29:10 PDT
Created attachment 20208 [details] Revised proposed patch Oops. I left emitDefineGetter() and emitDefineSetter() in CodeGenerator.h. Here's a fixed patch.
Maciej Stachowiak
Comment 5 2008-03-30 14:02:56 PDT
Comment on attachment 20208 [details] Revised proposed patch r=me
Cameron Zwarich (cpst)
Comment 6 2008-03-30 21:46:54 PDT
Landed in r31443.
Note You need to log in before you can comment on or make changes to this bug.