[Win] MSVC doesn't seem to like "friend class NeverDestroyed<Foo>"

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Fujii Hironori]

[Win] MSVC doesn't seem to like "friend class NeverDestroyed<Foo>"

While trying to build WebKit2 for Windows (Bug 181885), I see a lot of compilation errors that NeverDestroyed is not a friend like following:

> 1>------ Build started: Project: WebKit (WebKit\WebKit), Configuration: Debug x64 ------
> 1>NetworkProcess.cpp
> 1>C:\webkit\gb\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NeverDestroyed.h(50): error C2248: 'WebKit::NetworkProcess::NetworkProcess': cannot access private member declared in class 'WebKit::NetworkProcess'
> 1>C:\webkit\gb\Source\WebKit\NetworkProcess\NetworkProcess.cpp(104): note: see declaration of 'WebKit::NetworkProcess::NetworkProcess'
> 1>c:\webkit\gb\source\webkit\networkprocess\NetworkProcess.h(79): note: see declaration of 'WebKit::NetworkProcess'
> 1>C:\webkit\gb\Source\WebKit\NetworkProcess\NetworkProcess.cpp(100): note: see reference to function template instantiation 'WTF::NeverDestroyed<WebKit::NetworkProcess>::NeverDestroyed<>(void)' being compiled
> 1>C:\webkit\gb\Source\WebKit\NetworkProcess\NetworkProcess.cpp(100): note: see reference to function template instantiation 'WTF::NeverDestroyed<WebKit::NetworkProcess>::NeverDestroyed<>(void)' being compiled
> 1>Done building project "WebKit.vcxproj" -- FAILED.
> ========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

If I apply a following patch, it can build:

> diff --git a/Source/WebKit/NetworkProcess/NetworkProcess.h b/Source/WebKit/NetworkProcess/NetworkProcess.h
> index a9c9818dd03..15a7469cb23 100644
> --- a/Source/WebKit/NetworkProcess/NetworkProcess.h
> +++ b/Source/WebKit/NetworkProcess/NetworkProcess.h
> @@ -78,8 +78,8 @@ class Cache;
>  
>  class NetworkProcess : public ChildProcess, private DownloadManager::Client {
>      WTF_MAKE_NONCOPYABLE(NetworkProcess);
> -    friend class NeverDestroyed<NetworkProcess>;
> -    friend class NeverDestroyed<DownloadManager>;
> +    friend NeverDestroyed<NetworkProcess>;
> +    friend NeverDestroyed<DownloadManager>;
>  public:
>      static NetworkProcess& singleton();
>

[Fujii Hironori]

(In reply to Fujii Hironori from comment #0)
> [Win] MSVC doesn't seem to like "friend class NeverDestroyed<Foo>"
> 
> While trying to build WebKit2 for Windows (Bug 181885), 

Incorrect bug id. it's Bug 177202.

[Fujii Hironori]

I can't find an answer in this page.

friend declaration - cppreference.com
http://en.cppreference.com/w/cpp/language/friend

[Fujii Hironori]

https://timsong-cpp.github.io/cppwp/n4140/temp.friend

> template<class T> class task;
> template<class T> task<T>* preempt(task<T>*);
> 
> template<class T> class task {
>   friend void next_time();
>   friend void process(task<T>*);
>   friend task<T>* preempt<T>(task<T>*);
>   template<class C> friend int func(C);
> 
>   friend class task<int>;
>   template<class P> friend class frd;
> };
[...]
> [...] Similarly, each specialization of the task class template has the class template specialization task<int> as a friend, [...]

If I understand correctly, "friend class NeverDestroyed<Foo>" is a valid style.

[Fujii Hironori]

Specifying command line switch /std:c++14, /std:c++17 or /std:c++latest doesn't help at all. (I'm using VS 2017 version 15.5.2)

[Fujii Hironori]

Repro: <https://gist.github.com/fujii/fea40827887237053b537f48807a8963>
The template friend class, which belongs to a different namespace, can't access private member if its friend declaration is specified without the namespace and with class keyword.
I sent a bug report to MS compiler team.

[Fujii Hironori]

I got their reply:

> Looks like this is already fixed with VS2017 15.6 preview 3.

I also confirmed this problem was fixed by it.

[Fujii Hironori]

can't wait VS2017 15.6 release. reopen.

[Fujii Hironori]

Created attachment 332926 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 332926 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 332926 [details]
Patch

Clearing flags on attachment: 332926

Committed r228021: <https://trac.webkit.org/changeset/228021>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/37164230>