Bug 182058

Summary: Web Inspector: Remove duplicate preference update for WebAuthentication value
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, jiewen_tan, joepeck, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-24 12:58:40 PST
Remove duplicate preference update for WebAuthentication value WebPage::updatePreferences has an explicit update to the WebAuthentication setting, but this is already handled by the generated preferences code from the yaml earlier.
Attachments
[PATCH] Proposed Fix (1.47 KB, patch)
2018-01-24 12:59 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2018-01-24 12:59:54 PST
Created attachment 332189 [details] [PATCH] Proposed Fix The generated line is identical: DerivedSources/WebKit2/WebPageUpdatePreferences.cpp 305: WebCore::RuntimeEnabledFeatures::sharedFeatures().setWebAuthenticationEnabled(store.getBoolValueForKey(WebPreferencesKey::webAuthenticationEnabledKey()));
Blaze Burg
Comment 2 2018-01-24 13:33:39 PST
Comment on attachment 332189 [details] [PATCH] Proposed Fix rs=me
WebKit Commit Bot
Comment 3 2018-01-24 13:58:38 PST
Comment on attachment 332189 [details] [PATCH] Proposed Fix Clearing flags on attachment: 332189 Committed r227564: <https://trac.webkit.org/changeset/227564>
WebKit Commit Bot
Comment 4 2018-01-24 13:58:39 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-24 13:59:28 PST
<rdar://problem/36838394>
Jiewen Tan
Comment 6 2018-01-24 14:10:02 PST
(In reply to Joseph Pecoraro from comment #0) > Remove duplicate preference update for WebAuthentication value > > WebPage::updatePreferences has an explicit update to the WebAuthentication > setting, but this is already handled by the generated preferences code from > the yaml earlier. Oops. Thanks for fixing this. I was not aware that yaml also does this for me.
Note You need to log in before you can comment on or make changes to this bug.