Bug 182022

Summary:

REGRESSION (r213020): Selection highlight does not cover entire character preceding zero-width joiner (ZWJ)

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar, Regression

Version:

WebKit Nightly Build

Hardware:

Mac

OS:

macOS 10.12.4

See Also:

https://bugs.webkit.org/show_bug.cgi?id=181964
https://bugs.webkit.org/show_bug.cgi?id=181993

Bug Depends on:

168211

Bug Blocks:

Attachments:

Description	Flags
Test	none
[Screenshot] Expected - using system Safari on Sierra	none
[Screenshot] WebKit r213020 (and above) on Sierra	none

Daniel Bates

Reported 2018-01-23 15:54:25 PST

Created attachment 332088 [details] Test While investigating the macOS Sierra EWS test failure for the test fast/text/mac/select-character-before-zero-width-joiner.html in attachment #332038 [details] (patch for bug #181993) I noticed that the rendering of this test regressed in ToT WebKit on macOS Sierra. In particular, the selection highlight does not cover the entire '2' in the test with ToT WebKit. Perform the following: 1. Open the attached test case (this is the same test included in attachment #332038 [details]). Then the selection highlight does not cover the entire width of the '2'. But in system Safari the selection highlight does cover the entire width of the '2'. I am using system Safari version 10.1.2 (12603.3.8) on macOS Sierra (16G1004).

Attachments
Test (231 bytes, text/html) 2018-01-23 15:54 PST, Daniel Bates	no flags	Details
[Screenshot] Expected - using system Safari on Sierra (45.12 KB, image/png) 2018-01-23 15:56 PST, Daniel Bates	no flags	Details
[Screenshot] WebKit r213020 (and above) on Sierra (7.13 KB, image/png) 2018-01-23 15:59 PST, Daniel Bates	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2018-01-23 15:54:40 PST

From bisecting builds, the selection rendering behavior regressed in <https://trac.webkit.org/changeset/213020> (bug #168211).

Daniel Bates

Comment 2 2018-01-23 15:56:49 PST

Created attachment 332089 [details] [Screenshot] Expected - using system Safari on Sierra

Daniel Bates

Comment 3 2018-01-23 15:59:40 PST

Created attachment 332090 [details] [Screenshot] WebKit r213020 (and above) on Sierra

Radar WebKit Bug Importer

Comment 4 2018-01-23 16:02:25 PST

<rdar://problem/36798720>

Note You need to log in before you can comment on or make changes to this bug.