Bug 181998

Summary: Web Inspector: Network's columns shake when scrolling at non-default zoom level
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, nvasilyev, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2018-01-23 11:21:24 PST 
Network's columns shake when scrolling at non-default zoom level

Steps to reproduce:
1. Inspect a page with my network requests (<http://nytimes.com>)
2. Show Network tab
3. Scroll Network table
  => All is good
4. ⌘+ to zoom in a few times
5. Scroll Network table
  => Columns shaking

Notes:
• Seeing an assertion in this case: Table.js:811:27: CONSOLE ERROR Should not have undistributed pixels.
• getBoundingClientRect values appear to be fractional which is unaccounted for in the pixel distribution algorithm
Comment 1 Joseph Pecoraro 2018-01-23 11:21:30 PST 
<rdar://problem/36449808>
Comment 2 Joseph Pecoraro 2018-01-23 11:24:40 PST 
Created attachment 332045 [details]
[PATCH] Proposed Fix
Comment 3 Nikita Vasilyev 2018-01-23 15:01:28 PST 
Nice! I just tried the patch and I can confirm that such bug exists and this patch indeed fixes it.

I can't r+ since I'm still not a reviewer.
Comment 4 Matt Baker 2018-01-23 16:22:19 PST 
Comment on attachment 332045 [details]
[PATCH] Proposed Fix

r=me. I wonder if there are other places in the UI suffering from this same problem. If so it could warrant a utility function.
Comment 5 WebKit Commit Bot 2018-01-23 16:46:44 PST 
Comment on attachment 332045 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 332045

Committed r227463: <https://trac.webkit.org/changeset/227463>
Comment 6 WebKit Commit Bot 2018-01-23 16:46:45 PST 
All reviewed patches have been landed.  Closing bug.