Bug 181991

Summary: JSC should use a speculation fence on VM entry/exit
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, jfbastien, keith_miller, mark.lam, msaboff, pvollan, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch jfbastien: review+

Filip Pizlo
Reported 2018-01-23 10:09:59 PST
Patch forthcoming.
Attachments
the patch (3.67 KB, patch)
2018-01-23 10:12 PST, Filip Pizlo 		jfbastien: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-01-23 10:12:04 PST
Created attachment 332035 [details] the patch
Filip Pizlo
Comment 2 2018-01-23 10:12:11 PST
<rdar://problem/36304751>
Radar WebKit Bug Importer
Comment 3 2018-01-23 10:12:48 PST
<rdar://problem/36781062>
JF Bastien
Comment 4 2018-01-23 10:16:46 PST
Comment on attachment 332035 [details] the patch r=me
Mark Lam
Comment 5 2018-01-23 10:17:21 PST
Comment on attachment 332035 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/JavaScriptCore/ChangeLog:10 > + For a microbenchmark that just calls a native function (supplied via a Objective-C block) in a /a Objective-C/an Objective-C/. > Source/JavaScriptCore/ChangeLog:11 > + tight loop from JS is a 0% regression on x86 and a 11% regression on ARM64. I suggest /JS is a 0%/JS, performance shows a 0%/.
Filip Pizlo
Comment 6 2018-01-23 10:30:13 PST
Landed in https://trac.webkit.org/changeset/227424/webkit
Saam Barati
Comment 7 2018-01-23 12:39:24 PST
Comment on attachment 332035 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/WTF/wtf/Atomics.h:285 > +#if !OS(WINDOWS) Should we have someone who works on Windows implement this for them?
Saam Barati
Comment 8 2018-01-23 12:42:31 PST
Comment on attachment 332035 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332035&action=review > Source/JavaScriptCore/runtime/JSLock.cpp:126 > + WTF::speculationFence(); Do we not want this for entry/exit in and out of other native code. E.g, WebCore bindings?
Note You need to log in before you can comment on or make changes to this bug.