Summary: | Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Jiewen Tan <jiewen_tan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, ap, commit-queue, jiewen_tan, jlewis3, joepeck, rniwa, tsavell, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2018-01-22 14:58:19 PST
The earliest failure visible on the dashboard is https://trac.webkit.org/changeset/226646/webkit, but that change is unrelated. Marked as flaky https://trac.webkit.org/changeset/227451/webkit This test has become very flaky after https://trac.webkit.org/changeset/238877/webkit The diff is the same as the one above. https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r238912%20(1467)/results.html (In reply to Ryan Haddad from comment #3) > This test has become very flaky after > https://trac.webkit.org/changeset/238877/webkit > > The diff is the same as the one above. > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > r238912%20(1467)/results.html I don’t think so. I tried to ran the test 1000 times before and after my change. It more or less reserves the same level of flakiness. Also, I don’t think there is anything my patch could affect this test case as it doesn’t have any iframes. (In reply to Jiewen Tan from comment #4) > (In reply to Ryan Haddad from comment #3) > > This test has become very flaky after > > https://trac.webkit.org/changeset/238877/webkit > > > > The diff is the same as the one above. > > > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > > r238912%20(1467)/results.html > > I don’t think so. I tried to ran the test 1000 times before and after my > change. It more or less reserves the same level of flakiness. Also, I don’t > think there is anything my patch could affect this test case as it doesn’t > have any iframes. Hm, the flakiness dashboard shows a drastic increase in the number of failures starting yesterday. Even if it isn't your revision, something definitely changed. (In reply to Ryan Haddad from comment #5) > (In reply to Jiewen Tan from comment #4) > > (In reply to Ryan Haddad from comment #3) > > > This test has become very flaky after > > > https://trac.webkit.org/changeset/238877/webkit > > > > > > The diff is the same as the one above. > > > > > > https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/ > > > r238912%20(1467)/results.html > > > > I don’t think so. I tried to ran the test 1000 times before and after my > > change. It more or less reserves the same level of flakiness. Also, I don’t > > think there is anything my patch could affect this test case as it doesn’t > > have any iframes. > > Hm, the flakiness dashboard shows a drastic increase in the number of > failures starting yesterday. Even if it isn't your revision, something > definitely changed. How about I fix the thing and relieve us all. Created attachment 356689 [details]
Patch
(In reply to Jiewen Tan from comment #6) > How about I fix the thing and relieve us all. Works for me. Thanks, Jiewen! Comment on attachment 356689 [details]
Patch
Thanks Youenn for r+ it.
Comment on attachment 356689 [details] Patch Clearing flags on attachment: 356689 Committed r238935: <https://trac.webkit.org/changeset/238935> All reviewed patches have been landed. Closing bug. |