Summary: | Uncaught Exception: TypeError: this._textEditor.toggleUnexecutedCodeHighlights().then is not a function | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 183887 | ||||||
Attachments: |
|
Description
Nikita Vasilyev
2018-01-20 17:41:57 PST
This is poorly architectured (likely by me 3 years ago). The [c] icon can only have 3 states: - gray: disabled, can't be activated. - black: not activated. - blue: activated. The icon updates on setting change. The setting can only have two states: - enabled. - disabled. The setting change is used to update the icon state. Which is wrong, it doesn't even have all 3 states. The setting should only indicate user preference: enabled (when possible) and disabled. Instead, the setting is user as a communication channel to set the icon to deactivated state. Currently, the setting gets set to disabled when: - Enabling pretty-print. - Editing a script. Pretty-printing and editing shouldn't change the setting, yet these actions should set the icon to disabled state. (In reply to Nikita Vasilyev from comment #2) > The icon updates on setting change. The setting can only have two states: > - enabled. > - disabled. To clarify, by the setting I mean WI.enableControlFlowProfilerSetting object. It's not related to the settings GUI. Created attachment 336257 [details]
Patch
Comment on attachment 336257 [details]
Patch
r=me
Comment on attachment 336257 [details] Patch Clearing flags on attachment: 336257 Committed r229874: <https://trac.webkit.org/changeset/229874> All reviewed patches have been landed. Closing bug. |