Summary: | Safari Tech Preview can't use GitHub login at forums.swift.org | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon <jon> | ||||||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | ap, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer, youennf | ||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||
Version: | Safari Technology Preview | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | macOS 10.13 | ||||||||||||||
URL: | https://forums.swift.org | ||||||||||||||
Attachments: |
|
Description
Jon
2018-01-20 14:27:54 PST
Created attachment 331925 [details]
Patch
Comment on attachment 331925 [details] Patch Attachment 331925 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6169869 New failing tests: http/tests/security/contentSecurityPolicy/function-constructor-allowed.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/contentSecurityPolicy/object-redirect-blocked2.html http/tests/security/contentSecurityPolicy/embed-redirect-blocked.html http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html http/tests/security/contentSecurityPolicy/object-redirect-blocked.html http/tests/security/contentSecurityPolicy/iframe-redirect-blocked-by-frame-src.html http/tests/security/contentSecurityPolicy/1.1/child-src/frame-src-takes-precedence-over-child-src.html Created attachment 331929 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 331925 [details] Patch Attachment 331925 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6169880 New failing tests: http/tests/security/contentSecurityPolicy/embed-redirect-blocked3.html http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html http/tests/security/contentSecurityPolicy/object-redirect-blocked2.html http/tests/security/contentSecurityPolicy/object-redirect-blocked3.html http/tests/security/contentSecurityPolicy/iframe-redirect-blocked-by-child-src.html http/tests/security/blocked-on-redirect.html http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html http/tests/security/contentSecurityPolicy/embed-redirect-blocked.html http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html http/tests/security/contentSecurityPolicy/object-redirect-blocked.html http/tests/security/contentSecurityPolicy/iframe-redirect-blocked-by-frame-src.html http/tests/security/contentSecurityPolicy/embed-redirect-blocked2.html Created attachment 331930 [details]
Archive of layout-test-results from ews100 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 331932 [details]
Patch
Comment on attachment 331932 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331932&action=review r=me with comment. > Source/WebCore/loader/DocumentLoader.cpp:488 > + auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() && SchemeRegistry::canServiceWorkersHandleURLScheme(url.protocol().toStringWithoutCopying()); Variable name would be better with a *should* prefix. (In reply to Chris Dumez from comment #8) > Comment on attachment 331932 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=331932&action=review > > r=me with comment. > > > Source/WebCore/loader/DocumentLoader.cpp:488 > > + auto tryLoadingThroughServiceWorker = !frameLoader()->isReloadingFromOrigin() && m_frame->page() && RuntimeEnabledFeatures::sharedFeatures().serviceWorkerEnabled() && SchemeRegistry::canServiceWorkersHandleURLScheme(url.protocol().toStringWithoutCopying()); > > Variable name would be better with a *should* prefix. Youenn, will you be able to make this change today? Otherwise, I'll do it and land. Created attachment 331942 [details]
Patch
Thanks! Comment on attachment 331942 [details] Patch Clearing flags on attachment: 331942 Committed r227348: <https://trac.webkit.org/changeset/227348> All reviewed patches have been landed. Closing bug. |