Bug 181904 – [GTK] WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/response.py is crashing in the bots

• Component: WebDriver
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

This doesn't happen for me locally, but managed to reproduce it in another system. This is causing all other tests run after this one to fail, so we have two things to fix here:

 - A test causing a crash in the driver process makes all other tests to fail with connection refused error. This should be handled by the test runner, by launching a new driver process. I'll file a different a bug for this.

 - We are not handling the case of the browser failing to launch. We pass nullptr as the error to spawn and then use the returned value unconditionally.

Thread 1 (Thread 0x7f0a0e6e6880 (LWP 29784)):
#0  0x00007f0a0b2ace25 in g_mutex_lock () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gthread-posix.c:1336
---Type <return> to continue, or q <return> to quit---
#1  0x00007f0a0b80bc23 in g_subprocess_wait_async () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gio/gsubprocess.c:904
#2  0x000055a3ea11cf06 in WebDriver::SessionHost::launchBrowser(WTF::Function<void (WebDriver::SessionHost::Succeeded)>&&) ()
#3  0x000055a3ea118e15 in WebDriver::WebDriverService::newSession(WTF::RefPtr<WTF::JSONImpl::Object, WTF::DumbPtrTraits<WTF::JSONImpl::Object> >&&, WTF::Function<void (WebDriver::CommandResult&&)>&&) ()
#4  0x000055a3ea11a0f6 in WebDriver::WebDriverService::handleRequest(WebDriver::HTTPRequestHandler::Request&&, WTF::Function<void (WebDriver::HTTPRequestHandler::Response&&)>&&) ()
#5  0x000055a3ea12021d in WebDriver::HTTPServer::listen(unsigned int)::{lambda(_SoupServer*, _SoupMessage*, char const*, _GHashTable*, SoupClientContext*, void*)#1}::_FUN(_SoupServer*, _SoupMessage*, char const*, _GHashTable*, SoupClientContext*, void*) ()
#6  0x00007f0a0e28108f in call_handler () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-server.c:1259
#7  got_body () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-server.c:1400
#8  0x00007f0a0b542605 in g_closure_invoke () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gclosure.c:804
#9  0x00007f0a0b554482 in signal_emit_unlocked_R () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3635
#10 0x00007f0a0b55d021 in g_signal_emit_valist () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3391
#11 0x00007f0a0b55d432 in g_signal_emit () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3447
#12 0x00007f0a0e279b32 in io_read () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:792
#13 0x00007f0a0e27a01d in io_run_until () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:988
#14 0x00007f0a0e27ac3b in io_run () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-io.c:1059
#15 0x00007f0a0e27bea7 in soup_message_read_request () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-message-server-io.c:304
#16 0x00007f0a0b54566e in g_cclosure_marshal_VOID__OBJECTv () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gmarshal.c:2102
#17 0x00007f0a0b542834 in _g_closure_invoke_va () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gclosure.c:867
#18 0x00007f0a0b55cd0c in g_signal_emit_valist () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3300
#19 0x00007f0a0b55d432 in g_signal_emit () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/gobject/gsignal.c:3447
#20 0x00007f0a0e28e06f in listen_watch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/libsoup-2.57.1/libsoup/soup-socket.c:1237
#21 0x00007f0a0b2685da in g_main_dispatch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148
#22 g_main_context_dispatch () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813
#23 0x00007f0a0b268968 in g_main_context_iterate () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886
#24 0x00007f0a0b268c82 in g_main_loop_run () at /home/igalia/cgarcia/WebKit/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082
#25 0x000055a3ea15afe0 in WTF::RunLoop::run() ()
#26 0x000055a3ea112108 in WebDriver::WebDriverService::run(int, char**) ()
#27 0x000055a3ea0f0227 in main ()

[Carlos Garcia Campos]

I've skipped the test in r227267. I'll investigate the issue next week.

[Carlos Garcia Campos]

Created attachment 331921 [details]
Patch

[EWS Watchlist]

Attachment 331921 [details] did not pass style-queue:


ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:101:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:123:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:138:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/SessionHost.h:56:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebDriver/SessionHost.h:79:  Extra space before ( in function call  [whitespace/parens] [4]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 6 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Committed r227290: <https://trac.webkit.org/changeset/227290>

[Radar WebKit Bug Importer]

<rdar://problem/36731452>