Bug 181835

Summary: LayoutTest webrtc/captureCanvas-webrtc.html is flaky
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=170870
https://bugs.webkit.org/show_bug.cgi?id=177401
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2018-01-18 21:09:17 PST
LayoutTest webrtc/captureCanvas-webrtc.html is a flaky timeout and failure on macOS and iOS

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2FcaptureCanvas-webrtc.html

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/webrtc/captureCanvas-webrtc-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/webrtc/captureCanvas-webrtc-actual.txt
@@ -1,8 +1,8 @@
- 
+  
 
 PASS Setting up the connection 
 PASS Checking canvas is green 
 PASS Checking canvas is red 
 PASS Checking canvas is green again 
-PASS Checking canvas size change 
+FAIL Checking canvas size change promise_test: Unhandled rejection with value: "waitForVideoSize timed out, expected 640x480 but got 320x240"
Comment 1 Ryan Haddad 2018-01-29 16:37:42 PST
Test is already marked as flaky on iOS. Marked as flaky on macOS in https://trac.webkit.org/changeset/227763/webkit
Comment 2 youenn fablet 2019-11-04 03:18:50 PST
Created attachment 382728 [details]
Patch
Comment 3 WebKit Commit Bot 2019-11-04 05:51:27 PST
Comment on attachment 382728 [details]
Patch

Rejecting attachment 382728 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 382728, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=382728&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=181835&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 382728 from bug 181835.
Fetching: https://bugs.webkit.org/attachment.cgi?id=382728
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: bfff7b17e912673a6a5834153f0d93ae87202a6f and refs/remotes/origin/master differ, using rebase:
:040000 040000 a9b53e218aa131cfe363b7787744f91e2d75d165 abd72541804877bbdf9d14b889ba5d9855308678 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: bfff7b17e912673a6a5834153f0d93ae87202a6f and refs/remotes/origin/master differ, using rebase:
:040000 040000 a9b53e218aa131cfe363b7787744f91e2d75d165 abd72541804877bbdf9d14b889ba5d9855308678 M	LayoutTests
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.
Total errors found: 0 in 0 files

Full output: https://webkit-queues.webkit.org/results/13210414
Comment 4 WebKit Commit Bot 2019-11-05 01:10:23 PST
Comment on attachment 382728 [details]
Patch

Clearing flags on attachment: 382728

Committed r252045: <https://trac.webkit.org/changeset/252045>
Comment 5 WebKit Commit Bot 2019-11-05 01:10:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-11-05 01:11:22 PST
<rdar://problem/56896871>