Bug 181827

Summary:

Update XPCSPI.h

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Web Template Framework

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, thorton

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
proposed patch	none
proposed patch	none
proposed patch	none

Alexey Proskuryakov

Reported 2018-01-18 19:00:30 PST

rdar://problem/36393031

Attachments
proposed patch (1.94 KB, patch) 2018-01-18 20:18 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (1.94 KB, patch) 2018-01-18 21:30 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (6.77 KB, patch) 2018-01-18 21:53 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (2.07 KB, patch) 2018-01-18 21:54 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2018-01-18 20:18:24 PST

Created attachment 331702 [details] proposed patch

EWS Watchlist

Comment 2 2018-01-18 20:19:58 PST

Attachment 331702 [details] did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2018-01-18 21:30:28 PST

Created attachment 331709 [details] proposed patch

EWS Watchlist

Comment 4 2018-01-18 21:32:54 PST

Attachment 331709 [details] did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 5 2018-01-18 21:53:21 PST

Created attachment 331710 [details] proposed patch

Alexey Proskuryakov

Comment 6 2018-01-18 21:54:24 PST

Created attachment 331711 [details] proposed patch

EWS Watchlist

Comment 7 2018-01-18 21:56:22 PST

Attachment 331711 [details] did not pass style-queue: ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 8 2018-01-18 22:39:43 PST

Comment on attachment 331711 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=331711&action=review I am assuming this only affects iOS as this patch conditioanlizes on it. > Source/WTF/wtf/spi/darwin/XPCSPI.h:59 > +#define XPC_NOESCAPE __attribute__((__noescape__)) I am surprised this works on iOS. I guess clang accepts an attribute name with and without leading and trailing underscores. According to <https://clang.llvm.org/docs/AttributeReference.html#noescape-clang-noescape> clang recognizes __attribute__((noescape)).

Alexey Proskuryakov

Comment 9 2018-01-19 09:36:29 PST

> I am assuming this only affects iOS as this patch conditioanlizes on it. Both are affected. This patch adds XPC_NOESCAPE to the prototype unconditionally, but also defines it to empty on platforms that don't have it, such as those using older Mac SDKs. Newer Mac SDKs have it. > __attribute__((noescape)) Curious indeed. But it matches the definition in xpc/base.h.

WebKit Commit Bot

Comment 10 2018-01-19 10:09:27 PST

Comment on attachment 331711 [details] proposed patch Clearing flags on attachment: 331711 Committed r227212: <https://trac.webkit.org/changeset/227212>

WebKit Commit Bot

Comment 11 2018-01-19 10:09:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.