Bug 181793

Summary:

[css-align] 'overflow' keyword must precede the self-position and content-position value

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

CSS

Assignee:

Javier Fernandez <jfernandez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, graouts, jfernandez, koivisto, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.chromium.org/p/chromium/issues/detail?id=802098
https://bugzilla.mozilla.org/show_bug.cgi?id=1432148

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews112 for mac-sierra	none
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Archive of layout-test-results from ews206 for win-future	none
Patch	jfernandez: commit-queue+
Patch	none

Javier Fernandez

Reported 2018-01-18 04:31:39 PST

The CSS WG has resolved to restrict the overflow-alignment syntax to avoid ambiguities when used in the place-xx shorthand. https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434 Due to this decision, the new CSS syntax impose that the 'overflow' keyword must precede the 'self-position' or 'left' or 'right' keywords.

Attachments
Patch (76.45 KB, patch) 2018-01-18 07:16 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.33 MB, application/zip) 2018-01-18 08:18 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip) 2018-01-18 08:22 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews112 for mac-sierra (2.97 MB, application/zip) 2018-01-18 08:42 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.22 MB, application/zip) 2018-01-18 08:47 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews206 for win-future (12.07 MB, application/zip) 2018-01-18 09:08 PST, EWS Watchlist	no flags	Details
Patch (88.11 KB, patch) 2018-01-18 13:45 PST, Javier Fernandez	jfernandez: commit-queue+	Details Formatted Diff Diff
Patch (88.64 KB, patch) 2018-01-22 02:00 PST, Javier Fernandez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Javier Fernandez

Comment 1 2018-01-18 07:16:29 PST

Created attachment 331619 [details] Patch

EWS Watchlist

Comment 2 2018-01-18 08:18:11 PST

Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6121058 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html

EWS Watchlist

Comment 3 2018-01-18 08:18:12 PST

Created attachment 331622 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-01-18 08:22:20 PST

Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6121063 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html

EWS Watchlist

Comment 5 2018-01-18 08:22:22 PST

Created attachment 331623 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-01-18 08:42:53 PST

Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6121096 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html

EWS Watchlist

Comment 7 2018-01-18 08:42:54 PST

Created attachment 331625 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 8 2018-01-18 08:47:07 PST

Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6121103 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html fast/css-grid-layout/grid-content-alignment-overflow.html css3/overwrite-content-alignment.html fast/css-grid-layout/grid-align-justify-overflow.html

EWS Watchlist

Comment 9 2018-01-18 08:47:09 PST

Created attachment 331626 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 10 2018-01-18 09:08:01 PST

Comment on attachment 331619 [details] Patch Attachment 331619 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6121301 New failing tests: css3/overwrite-self-alignment.html css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html css3/overwrite-content-alignment.html

EWS Watchlist

Comment 11 2018-01-18 09:08:12 PST

Created attachment 331629 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Javier Fernandez

Comment 12 2018-01-18 13:45:24 PST

Created attachment 331656 [details] Patch

Antti Koivisto

Comment 13 2018-01-22 00:38:35 PST

Comment on attachment 331656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331656&action=review > Source/WebCore/ChangeLog:14 > + There were several discussions to avoid ambiguities with the complex > + values, specially when it comes to define the place-xxx shorthands. > + > + One of the sources of problems is the 'overflow-position' keyword. The > + CSS WG has decided to change the syntax of all the CSS Box Alignment > + properties so that the 'overflow-position' keyword always precede the > + 'self-position' or the 'content-position' keywords. It would be good to explain in the ChangeLog why these changes are not expected to be content breaking. They do require fixes to many LayoutTests.

Antti Koivisto

Comment 14 2018-01-22 00:41:04 PST

r=me

Javier Fernandez

Comment 15 2018-01-22 02:00:04 PST

Created attachment 331904 [details] Patch

WebKit Commit Bot

Comment 16 2018-01-22 09:01:56 PST

Comment on attachment 331904 [details] Patch Clearing flags on attachment: 331904 Committed r227297: <https://trac.webkit.org/changeset/227297>

WebKit Commit Bot

Comment 17 2018-01-22 09:01:58 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 18 2018-01-22 09:04:36 PST

<rdar://problem/36735686>

Note You need to log in before you can comment on or make changes to this bug.