Bug 181792

Summary: [css-align] 'left' and 'right' should parse as invalid in block/cross-axis alignment
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: CSSAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, ews-watchlist, graouts, koivisto, rniwa, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=802095
https://bugzilla.mozilla.org/show_bug.cgi?id=1432154
https://bugzilla.mozilla.org/show_bug.cgi?id=1430817
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews100 for mac-sierra
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Archive of layout-test-results from ews114 for mac-sierra
none
Patch none

Description Javier Fernandez 2018-01-18 04:28:55 PST
'The CSS WG has resolved that the 'left' and 'right' values should be removed from the block/cross-axis alignment properties (align-self and align-items). 

https://github.com/w3c/csswg-drafts/issues/1403#issuecomment-311722607

The same applies to the align-content and justify-content properties.
Comment 1 Javier Fernandez 2018-01-22 16:06:42 PST
Created attachment 331973 [details]
Patch
Comment 2 EWS Watchlist 2018-01-22 17:07:05 PST
Comment on attachment 331973 [details]
Patch

Attachment 331973 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6175573

New failing tests:
fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html
Comment 3 EWS Watchlist 2018-01-22 17:07:07 PST
Created attachment 331982 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 EWS Watchlist 2018-01-22 17:11:14 PST
Comment on attachment 331973 [details]
Patch

Attachment 331973 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6175732

New failing tests:
fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html
Comment 5 EWS Watchlist 2018-01-22 17:11:15 PST
Created attachment 331985 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 6 EWS Watchlist 2018-01-22 17:21:58 PST
Comment on attachment 331973 [details]
Patch

Attachment 331973 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6175530

New failing tests:
fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html
Comment 7 EWS Watchlist 2018-01-22 17:21:59 PST
Created attachment 331986 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 8 EWS Watchlist 2018-01-22 17:41:00 PST
Comment on attachment 331973 [details]
Patch

Attachment 331973 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6175791

New failing tests:
fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html
Comment 9 EWS Watchlist 2018-01-22 17:41:02 PST
Created attachment 331988 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 10 Javier Fernandez 2018-01-23 04:44:02 PST
Created attachment 332018 [details]
Patch
Comment 11 Antti Koivisto 2018-01-23 06:09:15 PST
Comment on attachment 332018 [details]
Patch

r=me
Comment 12 WebKit Commit Bot 2018-01-23 12:30:29 PST
Comment on attachment 332018 [details]
Patch

Clearing flags on attachment: 332018

Committed r227432: <https://trac.webkit.org/changeset/227432>
Comment 13 WebKit Commit Bot 2018-01-23 12:30:31 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Radar WebKit Bug Importer 2018-01-23 15:45:34 PST
<rdar://problem/36797976>