Summary: | WebCoreResourceHandleAsOperationQueueDelegate/ResourceHandleCFURLConnectionDelegateWithOperationQueue may be deleted in main thread callback | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Platform | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Mac | ||||||
OS: | macOS 10.13 | ||||||
Attachments: |
|
Description
Daniel Bates
2018-01-17 10:26:31 PST
Created attachment 331510 [details]
Patch
Comment on attachment 331510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331510&action=review > Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:172 > + auto protectedSelf = retainPtr(self); I'm not sure if this one's necessary because it doesn't do anything with self after calling the function which, until it is sent to the main thread, has a protector inside it's lambda capture. We should consider doing the same for the CFURLConnection code on Windows. Comment on attachment 331510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331510&action=review >> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:172 >> + auto protectedSelf = retainPtr(self); > > I'm not sure if this one's necessary because it doesn't do anything with self after calling the function which, until it is sent to the main thread, has a protector inside it's lambda capture. Oops! Will remove. (In reply to Alex Christensen from comment #4) > We should consider doing the same for the CFURLConnection code on Windows. Will do before landing. Committed r227073: <https://trac.webkit.org/changeset/227073> |