Bug 181746

Summary:

ASSERTION FAILED: !m_completionHandler in PingHandle::~PingHandle()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Platform

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, cdumez, ews-watchlist, mkwst, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac

OS:

macOS 10.13

Attachments:

Description	Flags
Patch and layout test	none

Daniel Bates

Reported 2018-01-17 09:47:21 PST

Using a debug build of WebKit, perform the following: 1. Open a new WebKit1 window in MiniBrowser. 2. Visit http://jet.com and wait for it to load. 3. Visit http://apple.com. Then we hit ASSERT(!m_completionHandler) is PingHandle::~PingHandle(): #0 0x00000001158c3b44 in ::WTFCrash() at /Volumes/Data/WebKitDev/OpenSource/Source/WTF/wtf/Assertions.cpp:272 #1 0x0000000104a09175 in WebCore::PingHandle::~PingHandle() at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/PingHandle.h:97 #2 0x0000000104a06e65 in WebCore::PingHandle::~PingHandle() at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/PingHandle.h:96 #3 0x0000000104a06e89 in WebCore::PingHandle::~PingHandle() at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/PingHandle.h:96 #4 0x0000000104a07610 in WebCore::PingHandle::canAuthenticateAgainstProtectionSpaceAsync(WebCore::ResourceHandle*, WebCore::ProtectionSpace const&) at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/WebCore.framework/PrivateHeaders/PingHandle.h:84 #5 0x0000000105eb23e7 in WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace(WebCore::ProtectionSpace const&) at /Volumes/Data/WebKitDev/OpenSource/Source/WebCore/platform/network/mac/ResourceHandleMac.mm:575 #6 0x0000000105ec53d9 in -[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]::$_3::operator()() at /Volumes/Data/WebKitDev/OpenSource/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:195 #7 0x0000000105ec51f9 in WTF::Function<void ()>::CallableWrapper<-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]::$_3>::call() at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/Function.h:101 #8 0x00000001158dfc8b in WTF::Function<void ()>::operator()() const at /Volumes/Data/WebKitDev/OpenSource/WebKitBuild/Debug/usr/local/include/wtf/Function.h:56 #9 0x0000000115902fdb in WTF::dispatchFunctionsFromMainThread() at /Volumes/Data/WebKitDev/OpenSource/Source/WTF/wtf/MainThread.cpp:130 #10 0x0000000115906141 in WTF::timerFired(__CFRunLoopTimer*, void*) at /Volumes/Data/WebKitDev/OpenSource/Source/WTF/wtf/mac/MainThreadMac.mm:110 #11 0x00007fff46bad9d4 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ () #12 0x00007fff46bad647 in __CFRunLoopDoTimer () #13 0x00007fff46bad14a in __CFRunLoopDoTimers () #14 0x00007fff46ba474b in __CFRunLoopRun () #15 0x00007fff46ba3b43 in CFRunLoopRunSpecific () #16 0x00007fff45e94f16 in RunCurrentEventLoopInMode () #17 0x00007fff45e94c86 in ReceiveNextEventCommon () #18 0x00007fff45e94a04 in _BlockUntilNextEventMatchingListInModeWithFilter () #19 0x00007fff44122f5f in _DPSNextEvent () #20 0x00007fff448b8b4c in -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] () #21 0x00007fff44117d6d in -[NSApplication run] () #22 0x00007fff440e6f1a in NSApplicationMain () #23 0x0000000100005109 in main at /Volumes/Data/WebKitDev/OpenSource/Tools/MiniBrowser/mac/main.m:32 #24 0x00007fff6f2aa021 in start ()

Attachments
Patch and layout test (6.05 KB, patch) 2018-01-17 10:02 PST, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-01-17 09:48:14 PST

<rdar://problem/36586248>

Daniel Bates

Comment 2 2018-01-17 10:02:47 PST

Created attachment 331507 [details] Patch and layout test

Chris Dumez

Comment 3 2018-01-17 10:19:20 PST

Comment on attachment 331507 [details] Patch and layout test r=me

Daniel Bates

Comment 4 2018-01-17 11:01:46 PST

Comment on attachment 331507 [details] Patch and layout test Clearing flags on attachment: 331507 Committed r227074: <https://trac.webkit.org/changeset/227074>

Daniel Bates

Comment 5 2018-01-17 11:01:47 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.