Bug 181690

Summary:

[Win] JSC compile error in runtime/DateConversion.cpp.

Product:

WebKit

Reporter:

Per Arne Vollan <pvollan>

Component:

Web Template Framework

Assignee:

Per Arne Vollan <pvollan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, commit-queue, ews-watchlist

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Per Arne Vollan 2018-01-16 10:31:00 PST

1> JavaScriptCore/runtime/DateConversion.cpp(35): fatal error C1083: Cannot open include file: 'wtf/text/win/WCharStringExtras.h': No such file or directory

Comment 1 Per Arne Vollan 2018-01-16 10:31:29 PST

<rdar://problem/36480409>

Comment 2 Per Arne Vollan 2018-01-16 10:35:50 PST

Created attachment 331400 [details]
Patch

Comment 3 Brent Fulgham 2018-01-16 10:37:41 PST

Comment on attachment 331400 [details]
Patch

r=me

Comment 4 EWS Watchlist 2018-01-16 10:38:27 PST

Attachment 331400 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/PlatformWin.cmake:3:  There should be exactly one empty line instead of 0 between "cf/TypeCastsCF.h" and "text/win/WCharStringExtras.h".  [list/emptyline] [5]
ERROR: Source/WTF/wtf/PlatformWin.cmake:38:  There should be exactly one empty line instead of 0 between "text" and "text/win".  [list/emptyline] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Per Arne Vollan 2018-01-16 10:40:32 PST

Comment on attachment 331400 [details]
Patch

Thanks for reviewing!

Comment 6 WebKit Commit Bot 2018-01-16 11:09:36 PST

Comment on attachment 331400 [details]
Patch

Clearing flags on attachment: 331400

Committed r226983: <https://trac.webkit.org/changeset/226983>

Comment 7 WebKit Commit Bot 2018-01-16 11:09:37 PST

All reviewed patches have been landed.  Closing bug.