Bug 181690

Summary: [Win] JSC compile error in runtime/DateConversion.cpp.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: Web Template FrameworkAssignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, ews-watchlist
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2018-01-16 10:31:00 PST
1> JavaScriptCore/runtime/DateConversion.cpp(35): fatal error C1083: Cannot open include file: 'wtf/text/win/WCharStringExtras.h': No such file or directory
Attachments
Patch (1.12 KB, patch)
2018-01-16 10:35 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-01-16 10:31:29 PST
<rdar://problem/36480409>
Per Arne Vollan
Comment 2 2018-01-16 10:35:50 PST
Created attachment 331400 [details] Patch
Brent Fulgham
Comment 3 2018-01-16 10:37:41 PST
Comment on attachment 331400 [details] Patch r=me
EWS Watchlist
Comment 4 2018-01-16 10:38:27 PST
Attachment 331400 [details] did not pass style-queue: ERROR: Source/WTF/wtf/PlatformWin.cmake:3: There should be exactly one empty line instead of 0 between "cf/TypeCastsCF.h" and "text/win/WCharStringExtras.h". [list/emptyline] [5] ERROR: Source/WTF/wtf/PlatformWin.cmake:38: There should be exactly one empty line instead of 0 between "text" and "text/win". [list/emptyline] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Per Arne Vollan
Comment 5 2018-01-16 10:40:32 PST
Comment on attachment 331400 [details] Patch Thanks for reviewing!
WebKit Commit Bot
Comment 6 2018-01-16 11:09:36 PST
Comment on attachment 331400 [details] Patch Clearing flags on attachment: 331400 Committed r226983: <https://trac.webkit.org/changeset/226983>
WebKit Commit Bot
Comment 7 2018-01-16 11:09:37 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.