| Summary: | Web Inspector: Styles Redesign: Long value causes bad wrapping | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, joepeck, nvasilyev, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 331319 [details] Patch HTML page for manual testing: http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/long-values.html Created attachment 331320 [details]
[Animated GIF] With patch applied
Created attachment 331360 [details]
Patch
Comment on attachment 331360 [details]
Patch
r=me
A property name that is super long ends up wrapping when editing, but going off the screen when not editing. Do we have a good story for what to do with long property names? Truncate to some max?
Comment on attachment 331360 [details] Patch Clearing flags on attachment: 331360 Committed r226995: <https://trac.webkit.org/changeset/226995> All reviewed patches have been landed. Closing bug. (In reply to Joseph Pecoraro from comment #5) > Comment on attachment 331360 [details] > Patch > > r=me > > A property name that is super long ends up wrapping when editing, but going > off the screen when not editing. Do we have a good story for what to do with > long property names? Truncate to some max? We truncate the middle part of values over 150 characters when not editing: token.value.trimMiddle(maxValueLength) It would be better to fit as many characters on a single line (or maybe two lines) without setting an arbitrary 150 character limit. This could be done in JS, but we'd need to truncate on sidebar resize. It would be nice to just use CSS for this, but it isn't supported. https://www.w3.org/wiki/Text-overflow_middle_cropping |
Created attachment 331246 [details] [IMAGE] Wrapping Issue Styles Redesign: Long value causes bad wrapping See attached screenshot. Steps to Reproduce: 1. Inspect data:text/html,<p>test 2. Show the styles sidebar for the <p> 3. Start adding: "color: asdfasdfasdfasdfasdfasdfasdfasdf..." => Sidebar gots crazy