Bug 181573

Summary:

Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+, commit-queue: commit-queue-

Keith Miller

Reported 2018-01-11 19:49:48 PST

Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION

Attachments
Patch (45.84 KB, patch) 2018-01-11 19:52 PST, Keith Miller	simon.fraser: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2018-01-11 19:52:55 PST

Created attachment 331160 [details] Patch

Keith Miller

Comment 2 2018-01-11 19:57:48 PST

I'm making this change begrudgingly on behalf of smfr. Despite the fact that the first result for "async iteration", "asynchronous iteration", and "web asynchronous iteration" on Google, DuckDuckGo, Bing, and Yahoo are all about JS!!!! Most are a direct link to the spec proposal GitHub!

WebKit Commit Bot

Comment 3 2018-01-11 20:58:51 PST

Comment on attachment 331160 [details] Patch Rejecting attachment 331160 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 331160, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6045118

Keith Miller

Comment 4 2018-01-11 23:59:36 PST

Committed r226879: <https://trac.webkit.org/changeset/226879>

Radar WebKit Bug Importer

Comment 5 2018-01-12 00:00:43 PST

<rdar://problem/36462455>

Note You need to log in before you can comment on or make changes to this bug.