Bug 181540

Summary:

[iOS] There should be no controls markup generated in fullscreen

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

iOS 11

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Patch for landing	eric.carlson: review+, graouts: commit-queue+

Antoine Quint

Reported 2018-01-11 09:48:44 PST

In https://bugs.webkit.org/show_bug.cgi?id=180144, we've made it so that we stop processing media events when in fullscreen on iOS. We need to take it further and remove all DOM contents to minimise the display refresh rate.

Attachments
Patch (7.46 KB, patch) 2018-01-11 09:51 PST, Antoine Quint	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.22 MB, application/zip) 2018-01-11 10:52 PST, EWS Watchlist	no flags	Details
Patch for landing (2.86 KB, patch) 2018-01-11 10:55 PST, Antoine Quint	eric.carlson: review+ graouts: commit-queue+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2018-01-11 09:48:58 PST

<rdar://problem/35060379>

Antoine Quint

Comment 2 2018-01-11 09:51:43 PST

Created attachment 331063 [details] Patch

Eric Carlson

Comment 3 2018-01-11 09:56:42 PST

Comment on attachment 331063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331063&action=review > Source/WebCore/ChangeLog:11 > + "visible" flag to "false" on the MediaControls, which will prevent any DOM content to > + be added to it. Nit: "prevent any DOM content from being added ..." might be better than "prevent any DOM content to be added ..."

EWS Watchlist

Comment 4 2018-01-11 10:52:28 PST

Comment on attachment 331063 [details] Patch Attachment 331063 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6036630 New failing tests: webgl/1.0.2/conformance/uniforms/uniform-default-values.html

EWS Watchlist

Comment 5 2018-01-11 10:52:30 PST

Created attachment 331072 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

Antoine Quint

Comment 6 2018-01-11 10:55:55 PST

Created attachment 331075 [details] Patch for landing

Antoine Quint

Comment 7 2018-01-11 12:18:43 PST

Committed r226795: <https://trac.webkit.org/changeset/226795>

Note You need to log in before you can comment on or make changes to this bug.