Bug 181512

Summary: Ensure there are no unsafe uses of MacroAssemblerARM64::dataTempRegister
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
saam: review+, saam: commit-queue-
Patch for landing - took care of review feedback and fixed build failure none

Michael Saboff
Reported 2018-01-10 18:13:11 PST
A recent bug <https://bugs.webkit.org/show_bug.cgi?id=181467> was found where there was an unsafe use of dataTempRegister in the ARM64 macro assembler. This is to check for any other potentially unsafe uses and fix them.
Attachments
Patch (2.39 KB, patch)
2018-01-10 18:25 PST, Michael Saboff 		saam: review+
saam: commit-queue-
DetailsFormatted DiffDiff
Patch for landing - took care of review feedback and fixed build failure (1.95 KB, patch)
2018-01-11 10:37 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-10 18:16:59 PST
<rdar://problem/36424103>
Michael Saboff
Comment 2 2018-01-10 18:25:39 PST
Created attachment 331006 [details] Patch
Saam Barati
Comment 3 2018-01-10 18:32:55 PST
Comment on attachment 331006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331006&action=review > Source/JavaScriptCore/ChangeLog:13 > + fix them if they might be used in elsewhere. In elsewhere => elsewhere
Michael Saboff
Comment 4 2018-01-11 10:37:44 PST
Created attachment 331070 [details] Patch for landing - took care of review feedback and fixed build failure
WebKit Commit Bot
Comment 5 2018-01-11 11:13:32 PST
Comment on attachment 331070 [details] Patch for landing - took care of review feedback and fixed build failure Clearing flags on attachment: 331070 Committed r226788: <https://trac.webkit.org/changeset/226788>
WebKit Commit Bot
Comment 6 2018-01-11 11:13:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.