Bug 18150

Summary:

LEAK: 39 Node on Acid3

Product:

WebKit

Reporter:

Matt Lilek <dev+webkit>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

hyatt, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

URL:

http://acid3.acidtests.org/

Attachments:

Description	Flags
Leaks output	none

Matt Lilek

Reported 2008-03-27 10:40:28 PDT

According to the leak check run-safari does when quitting Safari, we're leaking 39 Nodes after running Acid3. Using debug build of r31371 on 10.5.2 (9C7010) with Safari 3.1 (5525.13). MallocStackLogging is turned on, opening Safari, running Acid3 (empty page set as homepage), closing the browser window and waiting 10 seconds, then running leaks on Safari via the command line. Cached/uncached load does not make a difference.

Attachments
Leaks output (351.26 KB, text/plain) 2008-03-27 10:43 PDT, Matt Lilek	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Matt Lilek

Comment 1 2008-03-27 10:43:13 PDT

Created attachment 20126 [details] Leaks output

Eric Seidel (no email)

Comment 2 2008-04-14 23:13:38 PDT

This might be related to the obvious leak of SimplFontData objects from: SimpleFontData* CSSFontFaceSource::getFontData(const FontDescription& fontDescription, bool syntheticBold, bool syntheticItalic, CSSFontSelector* fontSelector) That method is named "get" but we return new'd pointers in the SVG fonts case. Bad bad.

Eric Seidel (no email)

Comment 3 2008-04-14 23:19:40 PDT

(In reply to comment #2) > This might be related to the obvious leak of SimplFontData objects from: > SimpleFontData* CSSFontFaceSource::getFontData(const FontDescription& > fontDescription, bool syntheticBold, bool syntheticItalic, CSSFontSelector* > fontSelector) > > That method is named "get" but we return new'd pointers in the SVG fonts case. > Bad bad. > Ok, I was wrong. These get stuffed off into m_fontDataTable and released when pruneTable() is called.

Note You need to log in before you can comment on or make changes to this bug.