Bug 181497

Summary:

Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, cdumez, commit-queue, dbates, ews-watchlist, japhet, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

181337

Bug Blocks:

181294

Attachments:

Description	Flags
Depends on other patches (will rebase later)	thorton: review+
Rebase on trunk	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
Speculative Windows build fix	none

Wenson Hsieh

Reported 2018-01-10 14:42:42 PST

This makes implementing promise-based blob data dragging on macOS considerably less painful.

Attachments
Depends on other patches (will rebase later) (25.70 KB, patch) 2018-01-10 14:48 PST, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Rebase on trunk (25.70 KB, patch) 2018-01-11 10:52 PST, Wenson Hsieh	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.62 MB, application/zip) 2018-01-11 12:12 PST, EWS Watchlist	no flags	Details
Speculative Windows build fix (26.13 KB, patch) 2018-01-11 12:18 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2018-01-10 14:48:53 PST

Created attachment 330968 [details] Depends on other patches (will rebase later)

Wenson Hsieh

Comment 2 2018-01-11 10:52:59 PST

Created attachment 331073 [details] Rebase on trunk

EWS Watchlist

Comment 3 2018-01-11 12:12:40 PST

Comment on attachment 331073 [details] Rebase on trunk Attachment 331073 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6037690 New failing tests: http/tests/workers/service/postmessage-after-sw-process-crash.https.html

EWS Watchlist

Comment 4 2018-01-11 12:12:42 PST

Created attachment 331089 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Wenson Hsieh

Comment 5 2018-01-11 12:18:28 PST

Created attachment 331093 [details] Speculative Windows build fix

WebKit Commit Bot

Comment 6 2018-01-11 14:32:48 PST

Comment on attachment 331093 [details] Speculative Windows build fix Clearing flags on attachment: 331093 Committed r226808: <https://trac.webkit.org/changeset/226808>

Radar WebKit Bug Importer

Comment 7 2018-01-11 14:34:28 PST

<rdar://problem/36450345>

Note You need to log in before you can comment on or make changes to this bug.