Bug 181462

Summary: REGRESSION(r201855): Web Inspector: Should see "length" autocompletion suggestion on a string literal
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2018-01-09 16:40:14 PST
Should see "length" autocompletion suggestion on a string literal Steps to Reproduce: 1. Inspect about:blank 2. js> "foo".len| => Expected a "length" autocompletion suggestion, but there is none
Attachments
[PATCH] Proposed Fix (3.17 KB, patch)
2018-01-09 16:51 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-09 16:40:43 PST
<rdar://problem/36390699>
Joseph Pecoraro
Comment 2 2018-01-09 16:51:57 PST
Created attachment 330862 [details] [PATCH] Proposed Fix
Matt Baker
Comment 3 2018-01-09 18:08:15 PST
Comment on attachment 330862 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2018-01-09 19:17:32 PST
Comment on attachment 330862 [details] [PATCH] Proposed Fix Clearing flags on attachment: 330862 Committed r226674: <https://trac.webkit.org/changeset/226674>
WebKit Commit Bot
Comment 5 2018-01-09 19:17:33 PST
All reviewed patches have been landed. Closing bug.
Blaze Burg
Comment 6 2018-01-10 11:04:20 PST
Comment on attachment 330862 [details] [PATCH] Proposed Fix Is there no way to test this code?
Joseph Pecoraro
Comment 7 2018-01-10 11:33:06 PST
(In reply to Brian Burg from comment #6) > Comment on attachment 330862 [details] > [PATCH] Proposed Fix > > Is there no way to test this code? In the frontend this is several levels deep in UI related code: CodeMirror CodeMirrorCompletionController JavaScriptRuntimeCompletionProvider We could mock some things and directly test methods with mock values on JavaScriptRuntimeCompletionProvider.
Note You need to log in before you can comment on or make changes to this bug.