Bug 181410

Summary: Add WKNavigationDelegate SPI exposing WebProcess crash reason
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2018-01-08 15:47:14 PST
Add WKNavigationDelegate SPI exposing WebProcess crash reason
Attachments
Patch (9.39 KB, patch)
2018-01-08 15:48 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (9.62 KB, patch)
2018-01-08 19:11 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-01-08 15:48:15 PST
Created attachment 330747 [details] Patch
Wenson Hsieh
Comment 2 2018-01-08 19:05:51 PST
Comment on attachment 330747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330747&action=review > Source/WebKit/UIProcess/Cocoa/NavigationState.mm:894 > +static _WKProcessTerminationReason toWKProcessTerminationReason(ProcessTerminationReason reason) Nit - I think WebKit style guidelines recommend not having the "to" prefix (https://webkit.org/code-style-guidelines/#names-verb). Maybe processTerminationReason is sufficient? > Source/WebKit/UIProcess/Cocoa/NavigationState.mm:927 > + if (m_navigationState.m_navigationDelegateMethods.webViewWebContentProcessDidTerminateWithReason) { Nit - Maybe this should go ahead of the webViewWebContentProcessDidTerminate check, so that if a delegate implements both versions, the SPI version is preferred. Or maybe this doesn't really matter :P
Alex Christensen
Comment 3 2018-01-08 19:11:44 PST
Created attachment 330779 [details] Patch
Alex Christensen
Comment 4 2018-01-08 19:27:34 PST
http://trac.webkit.org/r226610
Radar WebKit Bug Importer
Comment 5 2018-01-08 19:28:25 PST
<rdar://problem/36367341>
Note You need to log in before you can comment on or make changes to this bug.