Bug 181386

Summary: [Cairo] Use isolated fill and stroke source containers
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, ews-watchlist, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-01-08 05:05:33 PST
[Cairo] Use isolated fill and stroke source containers
Attachments
Patch (27.40 KB, patch)
2018-01-08 05:24 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (27.40 KB, patch)
2018-01-08 05:25 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (27.79 KB, patch)
2018-01-08 06:58 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-01-08 05:24:15 PST
Created attachment 330692 [details] Patch
Zan Dobersek
Comment 2 2018-01-08 05:25:05 PST
Created attachment 330693 [details] Patch
Carlos Garcia Campos
Comment 3 2018-01-08 05:33:27 PST
Comment on attachment 330693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330693&action=review > Source/WebCore/platform/graphics/cairo/CairoOperations.cpp:486 > + if (state.strokePattern) { Don't use { in this case > Source/WebCore/platform/graphics/cairo/CairoOperations.h:89 > + bool repeatX; > + bool repeatY; Should we initialize this for the default constructor?
Zan Dobersek
Comment 4 2018-01-08 06:58:10 PST
Created attachment 330702 [details] Patch for landing Addresses all the review comments
Zan Dobersek
Comment 5 2018-01-08 07:00:41 PST
Comment on attachment 330702 [details] Patch for landing Clearing flags on attachment: 330702 Committed r226511: <https://trac.webkit.org/changeset/226511>
Zan Dobersek
Comment 6 2018-01-08 07:00:45 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-01-08 07:01:27 PST
<rdar://problem/36348799>
Note You need to log in before you can comment on or make changes to this bug.