Bug 181369

Summary: Fix check-webkit-style issues with WebNSDataExtras.mm
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 181256    
Bug Blocks:    
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2018-01-06 20:26:29 PST
After converting Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m to Objective-C++ for Bug 181256, the check-webkit-style script finds a number of issues with its coding style. This bug tracks fixing all the known style issues found with check-webkit-style.
Attachments
Patch v1 (18.35 KB, patch)
2018-01-08 02:20 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2018-01-08 02:20:54 PST
Created attachment 330672 [details] Patch v1
WebKit Commit Bot
Comment 2 2018-01-08 13:02:09 PST
Comment on attachment 330672 [details] Patch v1 Clearing flags on attachment: 330672 Committed r226529: <https://trac.webkit.org/changeset/226529>
WebKit Commit Bot
Comment 3 2018-01-08 13:02:11 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-01-08 13:03:29 PST
<rdar://problem/36357331>
Note You need to log in before you can comment on or make changes to this bug.