Bug 181353 – Show Keyboard when re-launching WKWebView with a previously focused element

• Component: New Bugs
• Status: RESOLVED FIXED

[Megan Gardner]

Show Keyboard when re-launching WKWebView with a previously focused element

[Megan Gardner]

Created attachment 330603 [details]
Patch

[Tim Horton]

Comment on attachment 330603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330603&action=review

> Source/WebKit/UIProcess/PageClient.h:291
> +    virtual void startAssistingNode(const AssistedNodeInformation&, bool userIsInteracting, bool blurPreviousNode, API::Object* userData, bool changingActivityState) = 0;

Should stick this before the userData, that is traditionally the last argument

> Source/WebKit/UIProcess/ios/WKContentView.h:30
> -#import <UIKit/UIKit.h>
> +#import <UIKit/UIKitCore.h>

Definitely not.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:285
> +- (void)_startAssistingNode:(const WebKit::AssistedNodeInformation&)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode userObject:(NSObject <NSSecureCoding> *)userObject changingActivityState:(bool)changingActivityState;

Ditto the move-it-before-userObject thing

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:716
> +void WebPageProxy::startAutoscrollAtPosition(const WebCore::FloatPoint& positionInWidow)

Is this relevant? Also, widow?

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:896
> +        m_deferredNodeAssistanceArguments = std::make_unique<NodeAssistanceArguments>(NodeAssistanceArguments { information, userIsInteracting, blurPreviousNode, userDataObject , changingActivityState});

Weird extraneous space

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2717
> +    SetForScope<bool> changingActivityStateChange { m_changingActivityState, true };

You may want to scope this more closely to the activity state change? Can any of these other things call into script? Actually, can /any/ of these things synchronously call into script?

[Megan Gardner]

Created attachment 330623 [details]
Patch

[Tim Horton]

Comment on attachment 330623 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330623&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3868
> +- (void)_startAssistingNode:(const AssistedNodeInformation&)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode changingActivityState:(BOOL)changingActivityState userObject:(NSObject <NSSecureCoding> *)userObject 

You added a space at the end for some reason.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:2727
> +        SetForScope<bool> changingActivityStateChange { m_changingActivityState, true };

I see the logic in the name of the local but I also don’t know that it reads so great :)

[Megan Gardner]

Created attachment 330625 [details]
Patch

[Megan Gardner]

https://webkit.org/b/181353

[Radar WebKit Bug Importer]

<rdar://problem/36331806>