Summary: | SVGAnimatedListPropertyTearOff::synchronizeWrappersIfNeeded() should do nothing if the property is not animating | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Component: | SVG | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, simon.fraser, thorton, webkit-bug-importer, zalan, zimmermann | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Said Abou-Hallawa
2018-01-04 20:36:44 PST
Created attachment 330518 [details]
Patch
Created attachment 330556 [details]
Patch
Comment on attachment 330556 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330556&action=review > Source/WebCore/ChangeLog:9 > + This is a speculative change to fix a crash which appeared after r226065. This should say why there is no testcase. > Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h:147 > ASSERT(isAnimating()); > + if (!isAnimating()) We normally avoid patterns like this. If you think the assert and the if() are both needed, then add a comment saying "this should never happen, but we've seen it in the field. Please comment in bug ### i you hit this" or something. Created attachment 330559 [details]
Patch
Comment on attachment 330559 [details] Patch Clearing flags on attachment: 330559 Committed r226457: <https://trac.webkit.org/changeset/226457> All reviewed patches have been landed. Closing bug. |